From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] stabsread.c (define_symbol): Guard against bad stabstring input.
Date: Sat, 05 Mar 2011 00:37:00 -0000 [thread overview]
Message-ID: <4D7185C5.70505@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 74 bytes --]
I think I heard someone say that gdb should be proof against all inputs?
[-- Attachment #2: null13.txt --]
[-- Type: text/plain, Size: 690 bytes --]
2011-03-04 Michael Snyder <msnyder@vmware.com>
* stabsread.c (define_symbol): Guard against bad stabstring input.
Index: stabsread.c
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.c,v
retrieving revision 1.136
diff -u -p -r1.136 stabsread.c
--- stabsread.c 28 Feb 2011 23:32:27 -0000 1.136
+++ stabsread.c 5 Mar 2011 00:34:13 -0000
@@ -636,6 +636,9 @@ define_symbol (CORE_ADDR valu, char *str
{
p += 2;
p = strchr (p, ':');
+ if (p == NULL)
+ internal_error (__FILE__, __LINE__,
+ _("Bad stabs string '%s'"), string);
}
/* If a nameless stab entry, all we need is the type, not the symbol.
next reply other threads:[~2011-03-05 0:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 0:37 Michael Snyder [this message]
2011-03-05 0:43 ` Pedro Alves
2011-03-05 0:49 ` Pedro Alves
2011-03-11 21:35 ` Michael Snyder
2011-03-15 14:44 ` Pedro Alves
2011-03-15 18:07 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7185C5.70505@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox