From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4834 invoked by alias); 15 Mar 2011 14:25:12 -0000 Received: (qmail 4797 invoked by uid 22791); 15 Mar 2011 14:25:10 -0000 X-SWARE-Spam-Status: No, hits=0.8 required=5.0 tests=AWL,BAYES_00,KAM_STOCKTIP,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Mar 2011 14:25:06 +0000 Received: (qmail 21803 invoked from network); 15 Mar 2011 14:25:05 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Mar 2011 14:25:05 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] stabsread.c (define_symbol): Guard against bad stabstring input. Date: Tue, 15 Mar 2011 14:44:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.1; x86_64; ; ) Cc: Michael Snyder References: <4D7185C5.70505@vmware.com> <201103050049.14785.pedro@codesourcery.com> <4D7A90D8.8060903@vmware.com> In-Reply-To: <4D7A90D8.8060903@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103151425.01026.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00773.txt.bz2 On Friday 11 March 2011 21:15:04, Michael Snyder wrote: > Pedro Alves wrote: > > On Saturday 05 March 2011 00:42:59, Pedro Alves wrote: > >> On Saturday 05 March 2011 00:37:25, Michael Snyder wrote: > >>> I think I heard someone say that gdb should be proof against all inputs? > >> Yes, but bad inputs aren't gdb bugs, so those should be errors > >> or warnings, not internal_errors. > > > > for completeness: ... or "complaints", of which the symbol > > readers are the biggest users, exactly to complain about > > bad input debug info. complaints have the nice property > > that they warn once, and go quiet the next time the problem > > appears --- when we see a malformed debug info problem, we > > tend to see a lot of instances of the same in the same run, > > so that feature prevents terminal flooding with a bunch of > > duplicated warnings. > > > > Thanks. How about this? Sure, thanks. -- Pedro Alves