[RFA] TUI do not display current execution point

[RFA] TUI do not display current execution point

[Denis PILAT]

For binary files that have been compiled using a long absolute path, the old constant
MAX_LOCATOR_ELEMENT_LEN is not long enough.

tui_source_is_displayed() called from "tui-stack.c/tui_show_frame_info()" 
always returns false and we never execute "tui_set_is_exec_point_at ()" function.

The side effect is that the ">" character is never displayed in the left pane of the TUI window.

The problem was not easy to find, but the bellow patch is very simple and fix it.

OK for commit ?

-- 

Denis

--- ../../../../../vendor/GDB6.7.1/gdb/tui/tui-data.h   2007-12-12 18:05:18.000000000 +0100
+++ ./tui-data.h        2007-12-19 14:03:59.000000000 +0100
@@ -196,7 +196,7 @@ struct tui_command_element
 };


-#define MAX_LOCATOR_ELEMENT_LEN        100
+#define MAX_LOCATOR_ELEMENT_LEN        PATH_MAX

 /* Elements in the locator window content.  */
 struct tui_locator_element

Re: [RFA] TUI do not display current execution point

[Denis PILAT]

I forgot the ChangeLog entry, here it is with a better format for the patch:

-- 
Denis



2007-12-19  Denis Pilat  <denis.pilat@st.com>

	* tui/tui-data.h: MAX_LOCATOR_ELEMENT_LEN defined to PATH_MAX.



Index: tui-data.h
===================================================================
--- tui-data.h  (revision 615)
+++ tui-data.h  (working copy)
@@ -196,7 +196,7 @@ struct tui_command_element
 };


-#define MAX_LOCATOR_ELEMENT_LEN        100
+#define MAX_LOCATOR_ELEMENT_LEN        PATH_MAX

 /* Elements in the locator window content.  */
 struct tui_locator_element

RE: [RFA] TUI do not display current execution point

[Pierre Muller]

Code in gdb directory (utils.c and top.c) 
using PATH_MAX first check if that macro is defined.

Shouldn't you do the same in that patch?

Pierre Muller

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Denis PILAT
> Sent: Wednesday, December 19, 2007 2:30 PM
> To: gdb-patches
> Subject: [RFA] TUI do not display current execution point
> 
> For binary files that have been compiled using a long absolute path,
> the old constant
> MAX_LOCATOR_ELEMENT_LEN is not long enough.
> 
> tui_source_is_displayed() called from "tui-
> stack.c/tui_show_frame_info()"
> always returns false and we never execute "tui_set_is_exec_point_at ()"
> function.
> 
> The side effect is that the ">" character is never displayed in the
> left pane of the TUI window.
> 
> The problem was not easy to find, but the bellow patch is very simple
> and fix it.
> 
> OK for commit ?
> 
> --
> 
> Denis
> 
> --- ../../../../../vendor/GDB6.7.1/gdb/tui/tui-data.h   2007-12-12
> 18:05:18.000000000 +0100
> +++ ./tui-data.h        2007-12-19 14:03:59.000000000 +0100
> @@ -196,7 +196,7 @@ struct tui_command_element
>  };
> 
> 
> -#define MAX_LOCATOR_ELEMENT_LEN        100
> +#define MAX_LOCATOR_ELEMENT_LEN        PATH_MAX
> 
>  /* Elements in the locator window content.  */
>  struct tui_locator_element
> 
> 

Re: [RFA] TUI do not display current execution point

[Daniel Jacobowitz]

On Wed, Dec 19, 2007 at 02:56:18PM +0100, Pierre Muller wrote:
> Code in gdb directory (utils.c and top.c) 
> using PATH_MAX first check if that macro is defined.
> 
> Shouldn't you do the same in that patch?

Yes.  Also, please correct the ChangeLog entry; you're changing
MAX_LOCATOR_ELEMENT_LEN so that goes in parentheses.

Changing it to a bigger hardcoded constant is OK in this case,
although the right fix would be to remove the hardcoded length
(that's in the GNU Coding Standards, I think).

-- 
Daniel Jacobowitz
CodeSourcery

Re: [RFA] TUI do not display current execution point

[Denis PILAT]

You're both right, here is the new proposal:


-- 
Denis

2007-12-19  Denis Pilat  <denis.pilat@st.com>

	* tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN): Defined to a bigger
	value or to PATH_MAX when possible.


Index: tui-data.h
===================================================================
--- tui-data.h  (revision 615)
+++ tui-data.h  (working copy)
@@ -195,8 +195,11 @@ struct tui_command_element
   char *line;
 };

-
-#define MAX_LOCATOR_ELEMENT_LEN        100
+#ifdef PATH_MAX
+# define MAX_LOCATOR_ELEMENT_LEN        PATH_MAX
+#else
+# define MAX_LOCATOR_ELEMENT_LEN        1024
+#endif

 /* Elements in the locator window content.  */
 struct tui_locator_element





Daniel Jacobowitz wrote:
> On Wed, Dec 19, 2007 at 02:56:18PM +0100, Pierre Muller wrote:
>   
>> Code in gdb directory (utils.c and top.c) 
>> using PATH_MAX first check if that macro is defined.
>>
>> Shouldn't you do the same in that patch?
>>     
>
> Yes.  Also, please correct the ChangeLog entry; you're changing
> MAX_LOCATOR_ELEMENT_LEN so that goes in parentheses.
>
> Changing it to a bigger hardcoded constant is OK in this case,
> although the right fix would be to remove the hardcoded length
> (that's in the GNU Coding Standards, I think).
>
>   

Re: [RFA] TUI do not display current execution point

[Daniel Jacobowitz]

On Wed, Dec 19, 2007 at 04:27:21PM +0100, Denis PILAT wrote:
> You're both right, here is the new proposal:
>
>
> -- 
> Denis
>
> 2007-12-19  Denis Pilat  <denis.pilat@st.com>
>
> 	* tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN): Defined to a bigger
> 	value or to PATH_MAX when possible.

OK.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [RFA] TUI do not display current execution point

[Andreas Schwab]

Denis PILAT <denis.pilat@st.com> writes:

> --- ../../../../../vendor/GDB6.7.1/gdb/tui/tui-data.h   2007-12-12 18:05:18.000000000 +0100
> +++ ./tui-data.h        2007-12-19 14:03:59.000000000 +0100
> @@ -196,7 +196,7 @@ struct tui_command_element
> };
>
>
> -#define MAX_LOCATOR_ELEMENT_LEN        100
> +#define MAX_LOCATOR_ELEMENT_LEN        PATH_MAX

PATH_MAX may not be defined if there is no fixed limit.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [RFA] TUI do not display current execution point

[Denis PILAT]

Hi Daniel,

I have a problem accessing remote cvs from my work,

Could you please commit it for me ?
(Accepted patch is here: 
http://sources.redhat.com/ml/gdb-patches/2007-12/msg00315.html)

Thanks
Denis

Denis PILAT wrote:
> You're both right, here is the new proposal:
>
>

Re: [RFA] TUI do not display current execution point

[Joel Brobecker]

> I have a problem accessing remote cvs from my work,
> 
> Could you please commit it for me ?
> (Accepted patch is here: 
> http://sources.redhat.com/ml/gdb-patches/2007-12/msg00315.html)

I'm not Daniel, but I was working on GDB anyways, so I did the commit
for you :).

-- 
Joel