Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Denis PILAT'" <denis.pilat@st.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA] TUI do not display current execution point
Date: Wed, 19 Dec 2007 14:01:00 -0000	[thread overview]
Message-ID: <001001c84246$ed9fb5b0$c8df2110$@u-strasbg.fr> (raw)
In-Reply-To: <47691CE9.9020302@st.com>

Code in gdb directory (utils.c and top.c) 
using PATH_MAX first check if that macro is defined.

Shouldn't you do the same in that patch?

Pierre Muller

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Denis PILAT
> Sent: Wednesday, December 19, 2007 2:30 PM
> To: gdb-patches
> Subject: [RFA] TUI do not display current execution point
> 
> For binary files that have been compiled using a long absolute path,
> the old constant
> MAX_LOCATOR_ELEMENT_LEN is not long enough.
> 
> tui_source_is_displayed() called from "tui-
> stack.c/tui_show_frame_info()"
> always returns false and we never execute "tui_set_is_exec_point_at ()"
> function.
> 
> The side effect is that the ">" character is never displayed in the
> left pane of the TUI window.
> 
> The problem was not easy to find, but the bellow patch is very simple
> and fix it.
> 
> OK for commit ?
> 
> --
> 
> Denis
> 
> --- ../../../../../vendor/GDB6.7.1/gdb/tui/tui-data.h   2007-12-12
> 18:05:18.000000000 +0100
> +++ ./tui-data.h        2007-12-19 14:03:59.000000000 +0100
> @@ -196,7 +196,7 @@ struct tui_command_element
>  };
> 
> 
> -#define MAX_LOCATOR_ELEMENT_LEN        100
> +#define MAX_LOCATOR_ELEMENT_LEN        PATH_MAX
> 
>  /* Elements in the locator window content.  */
>  struct tui_locator_element
> 
> 




  parent reply	other threads:[~2007-12-19 13:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-19 13:41 Denis PILAT
2007-12-19 13:52 ` Denis PILAT
2007-12-19 14:01 ` Pierre Muller [this message]
2007-12-19 15:20   ` Daniel Jacobowitz
2007-12-19 15:28     ` Denis PILAT
2007-12-19 15:40       ` Daniel Jacobowitz
2007-12-21  7:38       ` Denis PILAT
2007-12-21 10:48         ` Joel Brobecker
2007-12-19 16:07 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001001c84246$ed9fb5b0$c8df2110$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=denis.pilat@st.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox