From: Denis PILAT <denis.pilat@st.com>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: [RFA] TUI do not display current execution point
Date: Wed, 19 Dec 2007 13:41:00 -0000 [thread overview]
Message-ID: <47691CE9.9020302@st.com> (raw)
For binary files that have been compiled using a long absolute path, the old constant
MAX_LOCATOR_ELEMENT_LEN is not long enough.
tui_source_is_displayed() called from "tui-stack.c/tui_show_frame_info()"
always returns false and we never execute "tui_set_is_exec_point_at ()" function.
The side effect is that the ">" character is never displayed in the left pane of the TUI window.
The problem was not easy to find, but the bellow patch is very simple and fix it.
OK for commit ?
--
Denis
--- ../../../../../vendor/GDB6.7.1/gdb/tui/tui-data.h 2007-12-12 18:05:18.000000000 +0100
+++ ./tui-data.h 2007-12-19 14:03:59.000000000 +0100
@@ -196,7 +196,7 @@ struct tui_command_element
};
-#define MAX_LOCATOR_ELEMENT_LEN 100
+#define MAX_LOCATOR_ELEMENT_LEN PATH_MAX
/* Elements in the locator window content. */
struct tui_locator_element
next reply other threads:[~2007-12-19 13:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 13:41 Denis PILAT [this message]
2007-12-19 13:52 ` Denis PILAT
2007-12-19 14:01 ` Pierre Muller
2007-12-19 15:20 ` Daniel Jacobowitz
2007-12-19 15:28 ` Denis PILAT
2007-12-19 15:40 ` Daniel Jacobowitz
2007-12-21 7:38 ` Denis PILAT
2007-12-21 10:48 ` Joel Brobecker
2007-12-19 16:07 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47691CE9.9020302@st.com \
--to=denis.pilat@st.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox