From: Daniel Jacobowitz <drow@false.org>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: 'Denis PILAT' <denis.pilat@st.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] TUI do not display current execution point
Date: Wed, 19 Dec 2007 15:20:00 -0000 [thread overview]
Message-ID: <20071219150400.GB21477@caradoc.them.org> (raw)
In-Reply-To: <001001c84246$ed9fb5b0$c8df2110$@u-strasbg.fr>
On Wed, Dec 19, 2007 at 02:56:18PM +0100, Pierre Muller wrote:
> Code in gdb directory (utils.c and top.c)
> using PATH_MAX first check if that macro is defined.
>
> Shouldn't you do the same in that patch?
Yes. Also, please correct the ChangeLog entry; you're changing
MAX_LOCATOR_ELEMENT_LEN so that goes in parentheses.
Changing it to a bigger hardcoded constant is OK in this case,
although the right fix would be to remove the hardcoded length
(that's in the GNU Coding Standards, I think).
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-12-19 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 13:41 Denis PILAT
2007-12-19 13:52 ` Denis PILAT
2007-12-19 14:01 ` Pierre Muller
2007-12-19 15:20 ` Daniel Jacobowitz [this message]
2007-12-19 15:28 ` Denis PILAT
2007-12-19 15:40 ` Daniel Jacobowitz
2007-12-21 7:38 ` Denis PILAT
2007-12-21 10:48 ` Joel Brobecker
2007-12-19 16:07 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071219150400.GB21477@caradoc.them.org \
--to=drow@false.org \
--cc=denis.pilat@st.com \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox