From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-52792-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6924 invoked by alias); 19 Dec 2007 15:04:12 -0000
Received: (qmail 6916 invoked by uid 22791); 19 Dec 2007 15:04:11 -0000
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Dec 2007 15:04:03 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id 1638398150; 	Wed, 19 Dec 2007 15:04:02 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) 	by nan.false.org (Postfix) with ESMTP id D35B29814F; 	Wed, 19 Dec 2007 15:04:01 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.68) 	(envelope-from <drow@caradoc.them.org>) 	id 1J50Sm-0007I4-Uy; Wed, 19 Dec 2007 10:04:01 -0500
Date: Wed, 19 Dec 2007 15:20:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: 'Denis PILAT' <denis.pilat@st.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] TUI do not display current execution point
Message-ID: <20071219150400.GB21477@caradoc.them.org>
Mail-Followup-To: Pierre Muller <muller@ics.u-strasbg.fr>, 	'Denis PILAT' <denis.pilat@st.com>, gdb-patches@sourceware.org
References: <47691CE9.9020302@st.com> <001001c84246$ed9fb5b0$c8df2110$@u-strasbg.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <001001c84246$ed9fb5b0$c8df2110$@u-strasbg.fr>
User-Agent: Mutt/1.5.17 (2007-12-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-12/txt/msg00314.txt.bz2

On Wed, Dec 19, 2007 at 02:56:18PM +0100, Pierre Muller wrote:
> Code in gdb directory (utils.c and top.c) 
> using PATH_MAX first check if that macro is defined.
> 
> Shouldn't you do the same in that patch?

Yes.  Also, please correct the ChangeLog entry; you're changing
MAX_LOCATOR_ELEMENT_LEN so that goes in parentheses.

Changing it to a bigger hardcoded constant is OK in this case,
although the right fix would be to remove the hardcoded length
(that's in the GNU Coding Standards, I think).

-- 
Daniel Jacobowitz
CodeSourcery