From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-52781-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23508 invoked by alias); 19 Dec 2007 13:56:20 -0000
Received: (qmail 23438 invoked by uid 22791); 19 Dec 2007 13:56:19 -0000
X-Spam-Check-By: sourceware.org
Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Dec 2007 13:56:12 +0000
Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) 	by ics.u-strasbg.fr (Postfix) with ESMTP id 2D0AD187021; 	Wed, 19 Dec 2007 15:00:19 +0100 (CET)
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Denis PILAT'" <denis.pilat@st.com>
Cc: <gdb-patches@sourceware.org>
References: <47691CE9.9020302@st.com>
In-Reply-To: <47691CE9.9020302@st.com>
Subject: RE: [RFA] TUI do not display current execution point
Date: Wed, 19 Dec 2007 14:01:00 -0000
Message-ID: <001001c84246$ed9fb5b0$c8df2110$@u-strasbg.fr>
MIME-Version: 1.0
Content-Type: text/plain; 	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 12.0
Content-Language: en-us
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-12/txt/msg00303.txt.bz2

Code in gdb directory (utils.c and top.c) 
using PATH_MAX first check if that macro is defined.

Shouldn't you do the same in that patch?

Pierre Muller

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Denis PILAT
> Sent: Wednesday, December 19, 2007 2:30 PM
> To: gdb-patches
> Subject: [RFA] TUI do not display current execution point
> 
> For binary files that have been compiled using a long absolute path,
> the old constant
> MAX_LOCATOR_ELEMENT_LEN is not long enough.
> 
> tui_source_is_displayed() called from "tui-
> stack.c/tui_show_frame_info()"
> always returns false and we never execute "tui_set_is_exec_point_at ()"
> function.
> 
> The side effect is that the ">" character is never displayed in the
> left pane of the TUI window.
> 
> The problem was not easy to find, but the bellow patch is very simple
> and fix it.
> 
> OK for commit ?
> 
> --
> 
> Denis
> 
> --- ../../../../../vendor/GDB6.7.1/gdb/tui/tui-data.h   2007-12-12
> 18:05:18.000000000 +0100
> +++ ./tui-data.h        2007-12-19 14:03:59.000000000 +0100
> @@ -196,7 +196,7 @@ struct tui_command_element
>  };
> 
> 
> -#define MAX_LOCATOR_ELEMENT_LEN        100
> +#define MAX_LOCATOR_ELEMENT_LEN        PATH_MAX
> 
>  /* Elements in the locator window content.  */
>  struct tui_locator_element
> 
>