[RFA] Add declaration in i386-tdep.h (for interix)

[RFA] Add declaration in i386-tdep.h (for interix)

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Still submitting small changes that I come across and will be needed for
the interix port...

2002-07-30  Joel Brobecker  <brobecker@gnat.com>

        * i386-tdep.h (skip_trampoline_code): Add forward declaration.
        Will be needed for the interix target.

OK to apply?

Thank you.
-- 
Joel

[-- Attachment #2: i386-tdep.h.diff --]
[-- Type: text/plain, Size: 635 bytes --]

Index: i386-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.h,v
retrieving revision 1.10
diff -c -3 -p -r1.10 i386-tdep.h
*** i386-tdep.h	4 Jul 2002 08:18:20 -0000	1.10
--- i386-tdep.h	30 Jul 2002 17:55:28 -0000
*************** struct gdbarch_tdep
*** 160,165 ****
--- 160,168 ----
  /* Size of the largest register.  */
  #define I386_MAX_REGISTER_SIZE	16
  
+ /* Functions exported from i386-tdep.c */
+ extern CORE_ADDR skip_trampoline_code (CORE_ADDR pc, char *name);
+ 
  /* Return the name of register REG.  */
  extern char const *i386_register_name (int reg);
  

Re: [RFA] Add declaration in i386-tdep.h (for interix)

[Andrew Cagney]

> 2002-07-30  Joel Brobecker  <brobecker@gnat.com>
> 
>         * i386-tdep.h (skip_trampoline_code): Add forward declaration.
>         Will be needed for the interix target.
> 

(The function would at least need to be namespace proofed - leading 
i386_ bit I 386 question)

BTW, Have you looked at the osabi mechanism?   The above may not even be 
needed.

Andrew

Re: [RFA] Add declaration in i386-tdep.h (for interix)

[Andrew Cagney]

> (The function would at least need to be namespace proofed - leading i386_ bit I 386 question)
Er, typo.  Try ....but i386 maintainer question.

Andrew

Re: [RFA] Add declaration in i386-tdep.h (for interix)

[Joel Brobecker]

> (The function would at least need to be namespace proofed - leading 
> i386_ bit I 386 question)

Ok, I'll wait for an i386 maintainer to comment. I can make this kind of
change, and I think it would make sense.

> BTW, Have you looked at the osabi mechanism?   The above may not even be 
> needed.

Yes, I am using this mechanism in the interix port to set the gdbarch
bits. That's where I need this definition, to get rid of one extern.

-- 
Joel

Re: [RFA] Add declaration in i386-tdep.h (for interix)

[Joel Brobecker]

Hello Mark,

I submitted this change, motivated by the fact that the interix-tdep
file needs this declaration. Andrew suggested that we namespace-proof
this function. I would be glad to change the name to, say,

    i386_skip_trampoline_code

But I would perfer to have your opinion/approval before going ahead,
since you are the i386 maintainer.

Thank you,

> 2002-07-30  Joel Brobecker  <brobecker@gnat.com>
> 
>         * i386-tdep.h (skip_trampoline_code): Add forward declaration.
>         Will be needed for the interix target.
> 
> OK to apply?
> 
> Thank you.
> -- 
> Joel

> Index: i386-tdep.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/i386-tdep.h,v
> retrieving revision 1.10
> diff -c -3 -p -r1.10 i386-tdep.h
> *** i386-tdep.h	4 Jul 2002 08:18:20 -0000	1.10
> --- i386-tdep.h	30 Jul 2002 17:55:28 -0000
> *************** struct gdbarch_tdep
> *** 160,165 ****
> --- 160,168 ----
>   /* Size of the largest register.  */
>   #define I386_MAX_REGISTER_SIZE	16
>   
> + /* Functions exported from i386-tdep.c */
> + extern CORE_ADDR skip_trampoline_code (CORE_ADDR pc, char *name);
> + 
>   /* Return the name of register REG.  */
>   extern char const *i386_register_name (int reg);
>   


-- 
Joel

Re: [RFA] Add declaration in i386-tdep.h (for interix)

[Mark Kettenis]

Joel Brobecker <brobecker@gnat.com> writes:

> Hello Mark,
> 
> I submitted this change, motivated by the fact that the interix-tdep
> file needs this declaration. Andrew suggested that we namespace-proof
> this function. I would be glad to change the name to, say,
> 
>     i386_skip_trampoline_code
> 
> But I would perfer to have your opinion/approval before going ahead,
> since you are the i386 maintainer.

Hmm, somehow this escaped from my attention.  Sorry 'bout that.

Andrew's suggestion is a good one.  However, since the code is
WIN32/PE-specific I'd prefer,

   i386_win32_skip_trampoline_code

or

   i386_pe_skip_trampoline_code

Consider the resulting patch pre-approved.

Thanks,

Mark

Re: [RFA] Add declaration in i386-tdep.h (for interix)

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

>    i386_pe_skip_trampoline_code
> 
> Consider the resulting patch pre-approved.

Hmmm, I made the change, and tested it on a x86 linux box.  But I could
not find a reference to this code anywhere, so I wonder if I did not
miss anything. So I prefer to wait until you can have a quick look
before I do the check-in. Sorry if I'm being too cautious.

2002-08-16  Joel Brobecker  <brobecker@gnat.com>

        * i386-tdep.c (i386_pe_skip_trampoline_code): renamed from
        skip_trampoline_code, for better namespace-proofing.

        * i386-tdep.h (i386_pe_skip_trampoline_code): Add declaration.

Ok to apply?
-- 
Joel

[-- Attachment #2: i386-tdep.diff --]
[-- Type: text/plain, Size: 1478 bytes --]

Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.79
diff -c -3 -p -r1.79 i386-tdep.c
*** i386-tdep.c	15 Aug 2002 17:36:57 -0000	1.79
--- i386-tdep.c	16 Aug 2002 21:38:13 -0000
*************** sunpro_static_transform_name (char *name
*** 1254,1260 ****
  /* Stuff for WIN32 PE style DLL's but is pretty generic really.  */
  
  CORE_ADDR
! skip_trampoline_code (CORE_ADDR pc, char *name)
  {
    if (pc && read_memory_unsigned_integer (pc, 2) == 0x25ff) /* jmp *(dest) */
      {
--- 1254,1260 ----
  /* Stuff for WIN32 PE style DLL's but is pretty generic really.  */
  
  CORE_ADDR
! i386_pe_skip_trampoline_code (CORE_ADDR pc, char *name)
  {
    if (pc && read_memory_unsigned_integer (pc, 2) == 0x25ff) /* jmp *(dest) */
      {
Index: i386-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.h,v
retrieving revision 1.11
diff -c -3 -p -r1.11 i386-tdep.h
*** i386-tdep.h	12 Aug 2002 19:05:33 -0000	1.11
--- i386-tdep.h	16 Aug 2002 21:38:13 -0000
*************** struct gdbarch_tdep
*** 160,165 ****
--- 160,168 ----
  /* Size of the largest register.  */
  #define I386_MAX_REGISTER_SIZE	16
  
+ /* Functions exported from i386-tdep.c */
+ extern CORE_ADDR i386_pe_skip_trampoline_code (CORE_ADDR pc, char *name);
+ 
  /* Return the name of register REG.  */
  extern char const *i386_register_name (int reg);
  

Re: [RFA] Add declaration in i386-tdep.h (for interix)

[Mark Kettenis]

   Date: Fri, 16 Aug 2002 14:44:51 -0700
   From: Joel Brobecker <brobecker@gnat.com>

   >    i386_pe_skip_trampoline_code
   > 
   > Consider the resulting patch pre-approved.

   Hmmm, I made the change, and tested it on a x86 linux box.  But I could
   not find a reference to this code anywhere, so I wonder if I did not
   miss anything. So I prefer to wait until you can have a quick look
   before I do the check-in. Sorry if I'm being too cautious.

There's a #ifdef'ed out reference to skip_trampoline_code in
config/i386/tm-cygwin.h.

Can you make sure that you end all comments with a dot (and two
spaces)?  Please make that change to the comment describing the
prototype in i386-tdep.h, and check it in.

Thanks,

Mark




   2002-08-16  Joel Brobecker  <brobecker@gnat.com>

	   * i386-tdep.c (i386_pe_skip_trampoline_code): renamed from
	   skip_trampoline_code, for better namespace-proofing.

	   * i386-tdep.h (i386_pe_skip_trampoline_code): Add declaration.

   Ok to apply?
   -- 
   Joel

   --0lnxQi9hkpPO77W3
   Content-Type: text/plain; charset=us-ascii
   Content-Disposition: attachment; filename="i386-tdep.diff"

   Index: i386-tdep.c
   ===================================================================
   RCS file: /cvs/src/src/gdb/i386-tdep.c,v
   retrieving revision 1.79
   diff -c -3 -p -r1.79 i386-tdep.c
   *** i386-tdep.c	15 Aug 2002 17:36:57 -0000	1.79
   --- i386-tdep.c	16 Aug 2002 21:38:13 -0000
   *************** sunpro_static_transform_name (char *name
   *** 1254,1260 ****
     /* Stuff for WIN32 PE style DLL's but is pretty generic really.  */

     CORE_ADDR
   ! skip_trampoline_code (CORE_ADDR pc, char *name)
     {
       if (pc && read_memory_unsigned_integer (pc, 2) == 0x25ff) /* jmp *(dest) */
	 {
   --- 1254,1260 ----
     /* Stuff for WIN32 PE style DLL's but is pretty generic really.  */

     CORE_ADDR
   ! i386_pe_skip_trampoline_code (CORE_ADDR pc, char *name)
     {
       if (pc && read_memory_unsigned_integer (pc, 2) == 0x25ff) /* jmp *(dest) */
	 {
   Index: i386-tdep.h
   ===================================================================
   RCS file: /cvs/src/src/gdb/i386-tdep.h,v
   retrieving revision 1.11
   diff -c -3 -p -r1.11 i386-tdep.h
   *** i386-tdep.h	12 Aug 2002 19:05:33 -0000	1.11
   --- i386-tdep.h	16 Aug 2002 21:38:13 -0000
   *************** struct gdbarch_tdep
   *** 160,165 ****
   --- 160,168 ----
     /* Size of the largest register.  */
     #define I386_MAX_REGISTER_SIZE	16

   + /* Functions exported from i386-tdep.c */
   + extern CORE_ADDR i386_pe_skip_trampoline_code (CORE_ADDR pc, char *name);
   + 
     /* Return the name of register REG.  */
     extern char const *i386_register_name (int reg);


   --0lnxQi9hkpPO77W3--

Re: [RFA] Add declaration in i386-tdep.h (for interix)

[Joel Brobecker]

> There's a #ifdef'ed out reference to skip_trampoline_code in
> config/i386/tm-cygwin.h.

I removed it in a separate patch. I hope that's ok.

> Can you make sure that you end all comments with a dot (and two
> spaces)?  Please make that change to the comment describing the
> prototype in i386-tdep.h, and check it in.

Ah, I'm really sorry about this, I should know by now. Fixed and committed.

>    2002-08-16  Joel Brobecker  <brobecker@gnat.com>
> 
> 	   * i386-tdep.c (i386_pe_skip_trampoline_code): renamed from
> 	   skip_trampoline_code, for better namespace-proofing.
> 
> 	   * i386-tdep.h (i386_pe_skip_trampoline_code): Add declaration.

-- 
Joel