From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12591 invoked by alias); 16 Aug 2002 22:26:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12583 invoked from network); 16 Aug 2002 22:26:42 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.250) by sources.redhat.com with SMTP; 16 Aug 2002 22:26:42 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g7GMQd1x001227; Sat, 17 Aug 2002 00:26:39 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g7GMQdWM000403; Sat, 17 Aug 2002 00:26:39 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.5/8.12.5/Submit) id g7GMQd7i000400; Sat, 17 Aug 2002 00:26:39 +0200 (CEST) Date: Fri, 16 Aug 2002 15:26:00 -0000 Message-Id: <200208162226.g7GMQd7i000400@elgar.kettenis.dyndns.org> From: Mark Kettenis To: brobecker@gnat.com CC: gdb-patches@sources.redhat.com In-reply-to: <20020816214451.GP906@gnat.com> (message from Joel Brobecker on Fri, 16 Aug 2002 14:44:51 -0700) Subject: Re: [RFA] Add declaration in i386-tdep.h (for interix) References: <20020730191256.GE19161@gnat.com> <20020815195252.GC906@gnat.com> <86bs83kqjv.fsf@elgar.kettenis.dyndns.org> <20020816214451.GP906@gnat.com> X-SW-Source: 2002-08/txt/msg00466.txt.bz2 Date: Fri, 16 Aug 2002 14:44:51 -0700 From: Joel Brobecker > i386_pe_skip_trampoline_code > > Consider the resulting patch pre-approved. Hmmm, I made the change, and tested it on a x86 linux box. But I could not find a reference to this code anywhere, so I wonder if I did not miss anything. So I prefer to wait until you can have a quick look before I do the check-in. Sorry if I'm being too cautious. There's a #ifdef'ed out reference to skip_trampoline_code in config/i386/tm-cygwin.h. Can you make sure that you end all comments with a dot (and two spaces)? Please make that change to the comment describing the prototype in i386-tdep.h, and check it in. Thanks, Mark 2002-08-16 Joel Brobecker * i386-tdep.c (i386_pe_skip_trampoline_code): renamed from skip_trampoline_code, for better namespace-proofing. * i386-tdep.h (i386_pe_skip_trampoline_code): Add declaration. Ok to apply? -- Joel --0lnxQi9hkpPO77W3 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="i386-tdep.diff" Index: i386-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/i386-tdep.c,v retrieving revision 1.79 diff -c -3 -p -r1.79 i386-tdep.c *** i386-tdep.c 15 Aug 2002 17:36:57 -0000 1.79 --- i386-tdep.c 16 Aug 2002 21:38:13 -0000 *************** sunpro_static_transform_name (char *name *** 1254,1260 **** /* Stuff for WIN32 PE style DLL's but is pretty generic really. */ CORE_ADDR ! skip_trampoline_code (CORE_ADDR pc, char *name) { if (pc && read_memory_unsigned_integer (pc, 2) == 0x25ff) /* jmp *(dest) */ { --- 1254,1260 ---- /* Stuff for WIN32 PE style DLL's but is pretty generic really. */ CORE_ADDR ! i386_pe_skip_trampoline_code (CORE_ADDR pc, char *name) { if (pc && read_memory_unsigned_integer (pc, 2) == 0x25ff) /* jmp *(dest) */ { Index: i386-tdep.h =================================================================== RCS file: /cvs/src/src/gdb/i386-tdep.h,v retrieving revision 1.11 diff -c -3 -p -r1.11 i386-tdep.h *** i386-tdep.h 12 Aug 2002 19:05:33 -0000 1.11 --- i386-tdep.h 16 Aug 2002 21:38:13 -0000 *************** struct gdbarch_tdep *** 160,165 **** --- 160,168 ---- /* Size of the largest register. */ #define I386_MAX_REGISTER_SIZE 16 + /* Functions exported from i386-tdep.c */ + extern CORE_ADDR i386_pe_skip_trampoline_code (CORE_ADDR pc, char *name); + /* Return the name of register REG. */ extern char const *i386_register_name (int reg); --0lnxQi9hkpPO77W3--