From: Joel Brobecker <brobecker@gnat.com>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Add declaration in i386-tdep.h (for interix)
Date: Fri, 16 Aug 2002 14:44:00 -0000 [thread overview]
Message-ID: <20020816214451.GP906@gnat.com> (raw)
In-Reply-To: <86bs83kqjv.fsf@elgar.kettenis.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
> i386_pe_skip_trampoline_code
>
> Consider the resulting patch pre-approved.
Hmmm, I made the change, and tested it on a x86 linux box. But I could
not find a reference to this code anywhere, so I wonder if I did not
miss anything. So I prefer to wait until you can have a quick look
before I do the check-in. Sorry if I'm being too cautious.
2002-08-16 Joel Brobecker <brobecker@gnat.com>
* i386-tdep.c (i386_pe_skip_trampoline_code): renamed from
skip_trampoline_code, for better namespace-proofing.
* i386-tdep.h (i386_pe_skip_trampoline_code): Add declaration.
Ok to apply?
--
Joel
[-- Attachment #2: i386-tdep.diff --]
[-- Type: text/plain, Size: 1478 bytes --]
Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.79
diff -c -3 -p -r1.79 i386-tdep.c
*** i386-tdep.c 15 Aug 2002 17:36:57 -0000 1.79
--- i386-tdep.c 16 Aug 2002 21:38:13 -0000
*************** sunpro_static_transform_name (char *name
*** 1254,1260 ****
/* Stuff for WIN32 PE style DLL's but is pretty generic really. */
CORE_ADDR
! skip_trampoline_code (CORE_ADDR pc, char *name)
{
if (pc && read_memory_unsigned_integer (pc, 2) == 0x25ff) /* jmp *(dest) */
{
--- 1254,1260 ----
/* Stuff for WIN32 PE style DLL's but is pretty generic really. */
CORE_ADDR
! i386_pe_skip_trampoline_code (CORE_ADDR pc, char *name)
{
if (pc && read_memory_unsigned_integer (pc, 2) == 0x25ff) /* jmp *(dest) */
{
Index: i386-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.h,v
retrieving revision 1.11
diff -c -3 -p -r1.11 i386-tdep.h
*** i386-tdep.h 12 Aug 2002 19:05:33 -0000 1.11
--- i386-tdep.h 16 Aug 2002 21:38:13 -0000
*************** struct gdbarch_tdep
*** 160,165 ****
--- 160,168 ----
/* Size of the largest register. */
#define I386_MAX_REGISTER_SIZE 16
+ /* Functions exported from i386-tdep.c */
+ extern CORE_ADDR i386_pe_skip_trampoline_code (CORE_ADDR pc, char *name);
+
/* Return the name of register REG. */
extern char const *i386_register_name (int reg);
next prev parent reply other threads:[~2002-08-16 21:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-30 12:18 Joel Brobecker
2002-08-01 15:16 ` Andrew Cagney
2002-08-01 15:22 ` Andrew Cagney
2002-08-02 11:18 ` Joel Brobecker
2002-08-15 12:52 ` Joel Brobecker
2002-08-16 4:10 ` Mark Kettenis
2002-08-16 14:44 ` Joel Brobecker [this message]
2002-08-16 15:26 ` Mark Kettenis
2002-08-16 17:12 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020816214451.GP906@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox