Re: [RFA] Add declaration in i386-tdep.h (for interix)

[Mark Kettenis <kettenis@chello.nl>]

   Date: Fri, 16 Aug 2002 14:44:51 -0700
   From: Joel Brobecker <brobecker@gnat.com>

   >    i386_pe_skip_trampoline_code
   > 
   > Consider the resulting patch pre-approved.

   Hmmm, I made the change, and tested it on a x86 linux box.  But I could
   not find a reference to this code anywhere, so I wonder if I did not
   miss anything. So I prefer to wait until you can have a quick look
   before I do the check-in. Sorry if I'm being too cautious.

There's a #ifdef'ed out reference to skip_trampoline_code in
config/i386/tm-cygwin.h.

Can you make sure that you end all comments with a dot (and two
spaces)?  Please make that change to the comment describing the
prototype in i386-tdep.h, and check it in.

Thanks,

Mark




   2002-08-16  Joel Brobecker  <brobecker@gnat.com>

	   * i386-tdep.c (i386_pe_skip_trampoline_code): renamed from
	   skip_trampoline_code, for better namespace-proofing.

	   * i386-tdep.h (i386_pe_skip_trampoline_code): Add declaration.

   Ok to apply?
   -- 
   Joel

   --0lnxQi9hkpPO77W3
   Content-Type: text/plain; charset=us-ascii
   Content-Disposition: attachment; filename="i386-tdep.diff"

   Index: i386-tdep.c
   ===================================================================
   RCS file: /cvs/src/src/gdb/i386-tdep.c,v
   retrieving revision 1.79
   diff -c -3 -p -r1.79 i386-tdep.c
   *** i386-tdep.c	15 Aug 2002 17:36:57 -0000	1.79
   --- i386-tdep.c	16 Aug 2002 21:38:13 -0000
   *************** sunpro_static_transform_name (char *name
   *** 1254,1260 ****
     /* Stuff for WIN32 PE style DLL's but is pretty generic really.  */

     CORE_ADDR
   ! skip_trampoline_code (CORE_ADDR pc, char *name)
     {
       if (pc && read_memory_unsigned_integer (pc, 2) == 0x25ff) /* jmp *(dest) */
	 {
   --- 1254,1260 ----
     /* Stuff for WIN32 PE style DLL's but is pretty generic really.  */

     CORE_ADDR
   ! i386_pe_skip_trampoline_code (CORE_ADDR pc, char *name)
     {
       if (pc && read_memory_unsigned_integer (pc, 2) == 0x25ff) /* jmp *(dest) */
	 {
   Index: i386-tdep.h
   ===================================================================
   RCS file: /cvs/src/src/gdb/i386-tdep.h,v
   retrieving revision 1.11
   diff -c -3 -p -r1.11 i386-tdep.h
   *** i386-tdep.h	12 Aug 2002 19:05:33 -0000	1.11
   --- i386-tdep.h	16 Aug 2002 21:38:13 -0000
   *************** struct gdbarch_tdep
   *** 160,165 ****
   --- 160,168 ----
     /* Size of the largest register.  */
     #define I386_MAX_REGISTER_SIZE	16

   + /* Functions exported from i386-tdep.c */
   + extern CORE_ADDR i386_pe_skip_trampoline_code (CORE_ADDR pc, char *name);
   + 
     /* Return the name of register REG.  */
     extern char const *i386_register_name (int reg);


   --0lnxQi9hkpPO77W3--