From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27162 invoked by alias); 16 Aug 2002 21:44:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27153 invoked from network); 16 Aug 2002 21:44:49 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 16 Aug 2002 21:44:49 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id BBEE0D2CBD; Fri, 16 Aug 2002 14:44:51 -0700 (PDT) Date: Fri, 16 Aug 2002 14:44:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Add declaration in i386-tdep.h (for interix) Message-ID: <20020816214451.GP906@gnat.com> References: <20020730191256.GE19161@gnat.com> <20020815195252.GC906@gnat.com> <86bs83kqjv.fsf@elgar.kettenis.dyndns.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0lnxQi9hkpPO77W3" Content-Disposition: inline In-Reply-To: <86bs83kqjv.fsf@elgar.kettenis.dyndns.org> User-Agent: Mutt/1.4i X-SW-Source: 2002-08/txt/msg00462.txt.bz2 --0lnxQi9hkpPO77W3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 624 > i386_pe_skip_trampoline_code > > Consider the resulting patch pre-approved. Hmmm, I made the change, and tested it on a x86 linux box. But I could not find a reference to this code anywhere, so I wonder if I did not miss anything. So I prefer to wait until you can have a quick look before I do the check-in. Sorry if I'm being too cautious. 2002-08-16 Joel Brobecker * i386-tdep.c (i386_pe_skip_trampoline_code): renamed from skip_trampoline_code, for better namespace-proofing. * i386-tdep.h (i386_pe_skip_trampoline_code): Add declaration. Ok to apply? -- Joel --0lnxQi9hkpPO77W3 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="i386-tdep.diff" Content-length: 1478 Index: i386-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/i386-tdep.c,v retrieving revision 1.79 diff -c -3 -p -r1.79 i386-tdep.c *** i386-tdep.c 15 Aug 2002 17:36:57 -0000 1.79 --- i386-tdep.c 16 Aug 2002 21:38:13 -0000 *************** sunpro_static_transform_name (char *name *** 1254,1260 **** /* Stuff for WIN32 PE style DLL's but is pretty generic really. */ CORE_ADDR ! skip_trampoline_code (CORE_ADDR pc, char *name) { if (pc && read_memory_unsigned_integer (pc, 2) == 0x25ff) /* jmp *(dest) */ { --- 1254,1260 ---- /* Stuff for WIN32 PE style DLL's but is pretty generic really. */ CORE_ADDR ! i386_pe_skip_trampoline_code (CORE_ADDR pc, char *name) { if (pc && read_memory_unsigned_integer (pc, 2) == 0x25ff) /* jmp *(dest) */ { Index: i386-tdep.h =================================================================== RCS file: /cvs/src/src/gdb/i386-tdep.h,v retrieving revision 1.11 diff -c -3 -p -r1.11 i386-tdep.h *** i386-tdep.h 12 Aug 2002 19:05:33 -0000 1.11 --- i386-tdep.h 16 Aug 2002 21:38:13 -0000 *************** struct gdbarch_tdep *** 160,165 **** --- 160,168 ---- /* Size of the largest register. */ #define I386_MAX_REGISTER_SIZE 16 + /* Functions exported from i386-tdep.c */ + extern CORE_ADDR i386_pe_skip_trampoline_code (CORE_ADDR pc, char *name); + /* Return the name of register REG. */ extern char const *i386_register_name (int reg); --0lnxQi9hkpPO77W3--