From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19513 invoked by alias); 16 Aug 2002 11:10:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19506 invoked from network); 16 Aug 2002 11:10:19 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.250) by sources.redhat.com with SMTP; 16 Aug 2002 11:10:19 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g7GBAG1x000369; Fri, 16 Aug 2002 13:10:16 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g7GBAGRg001530; Fri, 16 Aug 2002 13:10:16 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.5/8.12.5/Submit) id g7GBACoo001527; Fri, 16 Aug 2002 13:10:12 +0200 (CEST) To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Add declaration in i386-tdep.h (for interix) References: <20020730191256.GE19161@gnat.com> <20020815195252.GC906@gnat.com> From: Mark Kettenis Date: Fri, 16 Aug 2002 04:10:00 -0000 In-Reply-To: Joel Brobecker's message of "Thu, 15 Aug 2002 12:52:53 -0700" Message-ID: <86bs83kqjv.fsf@elgar.kettenis.dyndns.org> X-SW-Source: 2002-08/txt/msg00414.txt.bz2 Joel Brobecker writes: > Hello Mark, > > I submitted this change, motivated by the fact that the interix-tdep > file needs this declaration. Andrew suggested that we namespace-proof > this function. I would be glad to change the name to, say, > > i386_skip_trampoline_code > > But I would perfer to have your opinion/approval before going ahead, > since you are the i386 maintainer. Hmm, somehow this escaped from my attention. Sorry 'bout that. Andrew's suggestion is a good one. However, since the code is WIN32/PE-specific I'd prefer, i386_win32_skip_trampoline_code or i386_pe_skip_trampoline_code Consider the resulting patch pre-approved. Thanks, Mark