From: Farid Khaidari <khaidari.fg@gmail.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] gdb/riscv: recover FLEN from the NT_FPREGSET note size in core files
Date: Mon, 26 Oct 2026 13:01:49 +0300 [thread overview]
Message-ID: <20261026100154.3040316-1-khaidari.fg@gmail.com> (raw)
In-Reply-To: <32cc0c22-1fbf-4b10-92fa-906fad95564a@redhat.com>
Hi Kevin,
On 10/25/26 23:07, Kevin Buettner wrote:
> I don't think that riscv-tdep.c is the correct place to add knowledge
> about linux specific features. It seems to me that much of what you've
> done here ought to be placed in gdb/riscv-linux-tdep.c.
Thanks for the review. It is Linux-specific: FreeBSD lays out
NT_FPREGSET in 16-byte slots, so its size says nothing about FLEN
there. v2 moves the code to riscv-linux-tdep.c as a
core_read_description hook.
Farid
next prev parent reply other threads:[~2026-10-26 10:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 15:44 [PATCH 0/4] gdb/riscv: analyse a core file without the executable Farid Khaidari
2026-10-22 15:44 ` [PATCH 1/4] gdb/riscv: recover FLEN from the NT_FPREGSET note size in core files Farid Khaidari
2026-10-25 20:07 ` Kevin Buettner
2026-10-26 10:01 ` Farid Khaidari [this message]
2026-10-22 15:44 ` [PATCH 2/4] gdb/riscv: recover core file ISA features from AT_HWCAP Farid Khaidari
2026-10-22 15:44 ` [PATCH 3/4] gdb/riscv: test the "arch=" disassembler option Farid Khaidari
2026-10-22 15:44 ` [PATCH 4/4] gdb/riscv: disassemble an attribute-less object by the description ISA Farid Khaidari
2026-10-25 20:50 ` Kevin Buettner
2026-10-26 10:01 ` Farid Khaidari
2026-10-25 20:17 ` [PATCH 0/4] gdb/riscv: analyse a core file without the executable Kevin Buettner
2026-10-26 9:56 ` [PATCH v2 " Farid Khaidari
2026-10-26 9:56 ` [PATCH v2 1/4] gdb/riscv: recover FLEN from the NT_FPREGSET note size in core files Farid Khaidari
2026-10-26 9:56 ` [PATCH v2 2/4] gdb/riscv: recover core file ISA features from AT_HWCAP Farid Khaidari
2026-10-26 9:56 ` [PATCH v2 3/4] gdb/riscv: test the "arch=" disassembler option Farid Khaidari
2026-10-26 9:56 ` [PATCH v2 4/4] gdb/riscv: disassemble an attribute-less object by the description ISA Farid Khaidari
2026-10-27 14:31 ` [PATCH v2 0/4] gdb/riscv: analyse a core file without the executable Farid Khaidari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026100154.3040316-1-khaidari.fg@gmail.com \
--to=khaidari.fg@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox