From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wXP8Bksl32q6xxsAWB0awg (envelope-from ) for ; Mon, 26 Oct 2026 06:02:51 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=cx1whqAr; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 11D671E007; Mon, 26 Oct 2026 06:02:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 49B3A1E007 for ; Mon, 26 Oct 2026 06:02:50 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D87BA4BA2E2A for ; Mon, 26 Oct 2026 10:02:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D87BA4BA2E2A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=cx1whqAr Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 98B724BA23C4 for ; Mon, 26 Oct 2026 10:02:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 98B724BA23C4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 98B724BA23C4 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793008925; cv=none; b=u2hELqlnEGn2MjqXSvBFOMrY2NPUvGHSJV6xWXg/n8OyOLSPbLaRqQlUiVL9EfJZ9bdHbF0o/1l3qHC7Pz0yl1sNjndOPprScCaSYBfyGY9XttrR2ri9yK/M0EFEuvH5q82EHzruQvrkUBUm1FkLavnFbeMJeSyDcQ4uoDHoWwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793008925; c=relaxed/simple; bh=KDEJBDTr6sNAOTVMV9SSmtu+JxM5nMTrBH3Glw4MjFA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PgT7el+TM8oITkauvMIvB3uBxMRXgyUOCeEgFh2QoPNrJYa9uzPCUC+bstJEGT2AfNLpGDJYtSYO+3nrEdw2M+Im105KRHL9JK49NIvAElV3hB569aXhJWrNzwpP+Dh0742Gymf5T0SYsSiYjaWOGJZxI2fOLoViXmgf5maAfy4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=cx1whqAr DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 98B724BA23C4 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4a2153c8525so16691775e9.3 for ; Mon, 26 Oct 2026 03:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1793008924; x=1793613724; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HDGXmnkQwThLlwRWNE+TH1G+bPLlPo7L54BleuF1suo=; b=cx1whqAr1dKOH02jxvQeM5mCwAiXW778iP4axHEdnlMEe47oDPukMr6ysRRsyrzF9d Lyv7IVE04W5Od9T50KecMWnAdfv2M9c4HjEDIbfW4h7uEiX9TXb8A0kmgb1emhaLIJLw TVfEugKVS6OyM10CIry6/PM/7vVzu+wpujy5asqjYYBnccZ5li8sq0Z1zNPl5OikT14j JRV6ew5Zny7vQO0q4jCs8582kgZySKzf57zWZ8Z62O3iPN2FSnINFBfxYDoNFNBPD3g3 kZkxHjG8w1ES7p314jsAX4ByZfILGVY2+S7DbnzZ6uc1bgql5vNloHtr/yP31h820y+k rJvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793008924; x=1793613724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=HDGXmnkQwThLlwRWNE+TH1G+bPLlPo7L54BleuF1suo=; b=MHfu2srQfs2tqLMR3ZcHoqEIVBzfY+Mv7EjwTb1lXHWOMV7KjKAwlRGeLwgC6XkfaG TASxF+JoPQIosFecHq05sm7jLFn83KZU/7q/dAVdygvnGeCEDVtsLagH5VRj1MVJT9dv +I682QxSYcfcxQIOuRP8q6OesynIkUk5K9A89zcp5XyR8RtmANskldyMWuVdcv2CpE9l PMjzt4Ujx60Okrl0C5mjkNMyny2ZgIeWzsC7MyzWzURuojjCCyQL5dosEljDxPA0mqv+ WhjFSeTjsWgKZv6mNYRaVYNCdBM89PyVmmaLLhroeOqrWuyZdzeMpNzS9ubi+CMOYx8n WURg== X-Gm-Message-State: AFq9FYJYRIwvE5PPYk6mwKvj57Xk1bEwRs17NmAein0Gc+udgZCp/9tB OYwmuaPz5KXACCKQDdC4dHIJadMXv8SrRvt6zK7d2X5AUL0ssp1c8ADLpGraGf0MGKvhlh7teZM = X-Gm-Gg: AYBFou0fnXeIZ4n1VsjbfhLUhkyh/BEfsXK3PBRl1ROb+GUierxMaAetVB/1mPMiD13 yCrxWggc5+ub/n9h3o1GwJXKuVNHUP9m92ySTZXDiVTRCUOEchIvZMZQlYp14x85P+el5Q6iz6s +O68yrRs4bH11ePWJZUOJLSnZevV6PQmpobEcFOT7eHaJGuum9JCL/Kk4m0nTE0mJl3wvkScwMA KYGSUp616JiGLGrZaFhgAF2wmjLD9kEZyl266WuSrwQnoeXu/kg8e1XgSKWPMWqhmnwyf0kTYYL l43Sxhz+UN+bSGj6r08evNNBFB6ToXbm4jsLfzL+rvWjvJ4BS14oIS3qbpILpEwN0ok1k+5mPul D+RLGgiFGyGfrD0XAR1NEb5xQRhKZiCvsU1KMqfB2BALeEZtQX48Kkzea+/MNo4yz53zEz9p6EJ 20c3flt5UNHsP5PJzyKWmgr7A1XSz/6EWBdR5nmPbtQr+J0Ifbc24mf1WlfPc0V5frhfCZnafLd 4PgPy+fzueCapTWGne49f5dsJb5YcLvbtHCZnyMbKbVV/ksc2/EZAEqawfcocTU/YyYI4V6DT5f JblHFFTlVOfkRx9P3SddfoEq6/4ga7jL/Gk5lNZl5SiB2He/cDQ= X-Received: by 2002:a05:600c:190b:b0:4a5:cfc:1e95 with SMTP id 5b1f17b1804b1-4a50d0b6418mr77742035e9.33.1793008924263; Mon, 26 Oct 2026 03:02:04 -0700 (PDT) Received: from localhost.localdomain ([178.64.143.40]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ebcb8d5sm16102592f8f.28.2026.10.26.03.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 03:02:03 -0700 (PDT) From: Farid Khaidari To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] gdb/riscv: recover FLEN from the NT_FPREGSET note size in core files Date: Mon, 26 Oct 2026 13:01:49 +0300 Message-ID: <20261026100154.3040316-1-khaidari.fg@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <32cc0c22-1fbf-4b10-92fa-906fad95564a@redhat.com> References: <20261022154417.235510-1-khaidari.fg@gmail.com> <20261022154417.235510-2-khaidari.fg@gmail.com> <32cc0c22-1fbf-4b10-92fa-906fad95564a@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Kevin, On 10/25/26 23:07, Kevin Buettner wrote: > I don't think that riscv-tdep.c is the correct place to add knowledge > about linux specific features. It seems to me that much of what you've > done here ought to be placed in gdb/riscv-linux-tdep.c. Thanks for the review. It is Linux-specific: FreeBSD lays out NT_FPREGSET in 16-byte slots, so its size says nothing about FLEN there. v2 moves the code to riscv-linux-tdep.c as a core_read_description hook. Farid