Re: [PATCH 1/4] gdb/riscv: recover FLEN from the NT_FPREGSET note size in core files

[Kevin Buettner <kevinb@redhat.com>]

Hi Farid,

On 10/22/26 8:44 AM, Farid Khaidari wrote:
> A Linux kernel core has no float ABI in e_flags and no RISC-V
> attributes.  Opened without the executable, it gets an integer-only
> target description, and "p $fa0" fails with "Invalid register 'fa0'"
> even though the core holds the FP state.
> 
> The kernel writes 32 FP registers of FLEN bytes plus fcsr into
> NT_FPREGSET, so the note size gives FLEN.  Use it when e_flags says
> nothing.
> 
> The test core is a real kernel dump with a 264-byte NT_FPREGSET,
> i.e. FLEN = 8.
> 
> Signed-off-by: Farid Khaidari <khaidari.fg@gmail.com>
> ---
>  gdb/riscv-tdep.c                              |  89 +++++++++++++++++-

I don't think that riscv-tdep.c is the correct place to add knowledge
about linux specific features.  It seems to me that much of what you've
done here ought to be placed in gdb/riscv-linux-tdep.c.

If it's not truly linux-specific, but would be of benefit to other riscv
platforms, then this should be explained in the commit log as well as in
the code comments too.

Kevin