* [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all
@ 2021-04-13 12:22 Luis Machado via Gdb-patches
2021-04-13 12:24 ` Luis Machado via Gdb-patches
2021-04-13 13:36 ` Simon Marchi via Gdb-patches
0 siblings, 2 replies; 4+ messages in thread
From: Luis Machado via Gdb-patches @ 2021-04-13 12:22 UTC (permalink / raw)
To: gdb-patches
Replace use of %lx with %s.
gdb/ChangeLog:
YYYY-MM-DD Luis Machado <luis.machado@linaro.org>
* rs6000-tdep.c (ppc_displaced_step_fixup): Use %s to print
hex values.
---
gdb/rs6000-tdep.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index 2415aae342f..347014d6c2f 100644
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -995,8 +995,10 @@ ppc_displaced_step_fixup (struct gdbarch *gdbarch,
int regnum = (insn & ADDPCIS_TARGET_REGISTER) >> ADDPCIS_INSN_REGSHIFT;
/* Read and update the target value. */
regcache_cooked_read_unsigned (regs, regnum , ¤t_val);
- displaced_debug_printf ("addpcis target regnum %d was 0x%lx now 0x%lx",
- regnum, current_val, current_val + displaced_offset );
+ displaced_debug_printf ("addpcis target regnum %d was %s now %s",
+ regnum, paddress (gdbarch, current_val),
+ paddress (gdbarch, current_val
+ + displaced_offset));
regcache_cooked_write_unsigned (regs, regnum,
current_val + displaced_offset);
/* point the PC back at the non-displaced instruction. */
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all
2021-04-13 12:22 [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all Luis Machado via Gdb-patches
@ 2021-04-13 12:24 ` Luis Machado via Gdb-patches
2021-04-13 13:36 ` Simon Marchi via Gdb-patches
1 sibling, 0 replies; 4+ messages in thread
From: Luis Machado via Gdb-patches @ 2021-04-13 12:24 UTC (permalink / raw)
To: gdb-patches
Ignore the 6/6. I had a few more cleanups in the queue, but I'm sending
those later.
On 4/13/21 9:22 AM, Luis Machado wrote:
> Replace use of %lx with %s.
>
> gdb/ChangeLog:
>
> YYYY-MM-DD Luis Machado <luis.machado@linaro.org>
>
> * rs6000-tdep.c (ppc_displaced_step_fixup): Use %s to print
> hex values.
> ---
> gdb/rs6000-tdep.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
> index 2415aae342f..347014d6c2f 100644
> --- a/gdb/rs6000-tdep.c
> +++ b/gdb/rs6000-tdep.c
> @@ -995,8 +995,10 @@ ppc_displaced_step_fixup (struct gdbarch *gdbarch,
> int regnum = (insn & ADDPCIS_TARGET_REGISTER) >> ADDPCIS_INSN_REGSHIFT;
> /* Read and update the target value. */
> regcache_cooked_read_unsigned (regs, regnum , ¤t_val);
> - displaced_debug_printf ("addpcis target regnum %d was 0x%lx now 0x%lx",
> - regnum, current_val, current_val + displaced_offset );
> + displaced_debug_printf ("addpcis target regnum %d was %s now %s",
> + regnum, paddress (gdbarch, current_val),
> + paddress (gdbarch, current_val
> + + displaced_offset));
> regcache_cooked_write_unsigned (regs, regnum,
> current_val + displaced_offset);
> /* point the PC back at the non-displaced instruction. */
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all
2021-04-13 12:22 [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all Luis Machado via Gdb-patches
2021-04-13 12:24 ` Luis Machado via Gdb-patches
@ 2021-04-13 13:36 ` Simon Marchi via Gdb-patches
2021-04-13 13:50 ` Luis Machado via Gdb-patches
1 sibling, 1 reply; 4+ messages in thread
From: Simon Marchi via Gdb-patches @ 2021-04-13 13:36 UTC (permalink / raw)
To: Luis Machado, gdb-patches
On 2021-04-13 8:22 a.m., Luis Machado via Gdb-patches wrote:
> Replace use of %lx with %s.
>
> gdb/ChangeLog:
>
> YYYY-MM-DD Luis Machado <luis.machado@linaro.org>
>
> * rs6000-tdep.c (ppc_displaced_step_fixup): Use %s to print
> hex values.
> ---
> gdb/rs6000-tdep.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
> index 2415aae342f..347014d6c2f 100644
> --- a/gdb/rs6000-tdep.c
> +++ b/gdb/rs6000-tdep.c
> @@ -995,8 +995,10 @@ ppc_displaced_step_fixup (struct gdbarch *gdbarch,
> int regnum = (insn & ADDPCIS_TARGET_REGISTER) >> ADDPCIS_INSN_REGSHIFT;
> /* Read and update the target value. */
> regcache_cooked_read_unsigned (regs, regnum , ¤t_val);
> - displaced_debug_printf ("addpcis target regnum %d was 0x%lx now 0x%lx",
> - regnum, current_val, current_val + displaced_offset );
> + displaced_debug_printf ("addpcis target regnum %d was %s now %s",
> + regnum, paddress (gdbarch, current_val),
> + paddress (gdbarch, current_val
> + + displaced_offset));
> regcache_cooked_write_unsigned (regs, regnum,
> current_val + displaced_offset);
> /* point the PC back at the non-displaced instruction. */
>
LGTM, thanks.
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all
2021-04-13 13:36 ` Simon Marchi via Gdb-patches
@ 2021-04-13 13:50 ` Luis Machado via Gdb-patches
0 siblings, 0 replies; 4+ messages in thread
From: Luis Machado via Gdb-patches @ 2021-04-13 13:50 UTC (permalink / raw)
To: Simon Marchi, gdb-patches
On 4/13/21 10:36 AM, Simon Marchi wrote:
>
>
> On 2021-04-13 8:22 a.m., Luis Machado via Gdb-patches wrote:
>> Replace use of %lx with %s.
>>
>> gdb/ChangeLog:
>>
>> YYYY-MM-DD Luis Machado <luis.machado@linaro.org>
>>
>> * rs6000-tdep.c (ppc_displaced_step_fixup): Use %s to print
>> hex values.
>> ---
>> gdb/rs6000-tdep.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
>> index 2415aae342f..347014d6c2f 100644
>> --- a/gdb/rs6000-tdep.c
>> +++ b/gdb/rs6000-tdep.c
>> @@ -995,8 +995,10 @@ ppc_displaced_step_fixup (struct gdbarch *gdbarch,
>> int regnum = (insn & ADDPCIS_TARGET_REGISTER) >> ADDPCIS_INSN_REGSHIFT;
>> /* Read and update the target value. */
>> regcache_cooked_read_unsigned (regs, regnum , ¤t_val);
>> - displaced_debug_printf ("addpcis target regnum %d was 0x%lx now 0x%lx",
>> - regnum, current_val, current_val + displaced_offset );
>> + displaced_debug_printf ("addpcis target regnum %d was %s now %s",
>> + regnum, paddress (gdbarch, current_val),
>> + paddress (gdbarch, current_val
>> + + displaced_offset));
>> regcache_cooked_write_unsigned (regs, regnum,
>> current_val + displaced_offset);
>> /* point the PC back at the non-displaced instruction. */
>>
>
>
> LGTM, thanks.
>
> Simon
>
Thanks, pushed now.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-13 13:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 12:22 [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all Luis Machado via Gdb-patches
2021-04-13 12:24 ` Luis Machado via Gdb-patches
2021-04-13 13:36 ` Simon Marchi via Gdb-patches
2021-04-13 13:50 ` Luis Machado via Gdb-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox