From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UmCLILKhdWBpNAAAWB0awg (envelope-from ) for ; Tue, 13 Apr 2021 09:50:42 -0400 Received: by simark.ca (Postfix, from userid 112) id 779391F104; Tue, 13 Apr 2021 09:50:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CE5C41E01F for ; Tue, 13 Apr 2021 09:50:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3667639450D3; Tue, 13 Apr 2021 13:50:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3667639450D3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1618321841; bh=ETA8nIO6FHZflaOwqpitfrJBOi+7iLNAA2zesqGKpw8=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=vGQSkrqHKmd29cqQfbqPxZY9Lsm0V2jdq3LeVamEflwhHotQyVr3YAh2Lb3Aj1JRP LUaUhB16dK2ArCklQfCg6aINhZmnDDoI1iZAvreZBBg19nVh+GnnzM+a6w7qtvOAGh 6ZFi3QEjTXII4O7NB/KiQiL7iOmA8C1mFc6/gqIY= Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by sourceware.org (Postfix) with ESMTPS id 256723854804 for ; Tue, 13 Apr 2021 13:50:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 256723854804 Received: by mail-qk1-x730.google.com with SMTP id 18so999493qkl.3 for ; Tue, 13 Apr 2021 06:50:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ETA8nIO6FHZflaOwqpitfrJBOi+7iLNAA2zesqGKpw8=; b=K5UpgCJVkf0LigCrxzlmpvMmkZoKAmWCan5y4vKn9WOiY0t/euKxFEJ5h3vbBsqb1B rdDPRAkJuZMCDDUwRP149lR9HdFkTRm+hqoia1mrk6wPruSehrf0HeGGEhYIi9Fx3wfU qXs8tXvRcsVH3Oo0Pu7MEJZK2Mr8DHF6vM7rNvuAZPne9A+avL4Onn21JH1CDAzbG1lx kHrMPtbgqvpis0m2zUrimD2dBAYnBaA5VFN3s0bjhCLEPTdK0H8KbGVWmCw3MnzdVSyN UUdeL+c5WLviHe+wvZBRGed5iDudXr8ZJ+CudGOHJdmonCMxc22Wjt5c4PNp0nwTIdAj J3pw== X-Gm-Message-State: AOAM532fEDTii+TyRpvehmTvNkuGiI+tJxUboQAXm+qhT7LkGHTCOYC7 c8MtSwjsfeRvrKghfOe4vfcm+EWctgDmHg== X-Google-Smtp-Source: ABdhPJyR8MAerJB0gv6NYG+22KStwiLH/FztVx16Ch9W0AweVrEKwKiA1YCjSiR3/tr9AGMKtRJSDg== X-Received: by 2002:a37:a1d3:: with SMTP id k202mr25401499qke.97.1618321837693; Tue, 13 Apr 2021 06:50:37 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2841:b15b:1248:f1ec:bed5? ([2804:7f0:4841:2841:b15b:1248:f1ec:bed5]) by smtp.gmail.com with ESMTPSA id b15sm5694467qtg.82.2021.04.13.06.50.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 06:50:37 -0700 (PDT) Subject: Re: [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all To: Simon Marchi , gdb-patches@sourceware.org References: <20210413122221.1675458-1-luis.machado@linaro.org> <58cfb01f-48c9-575e-da53-4a06274c5d69@polymtl.ca> Message-ID: <790f6af3-25d9-7d9e-1164-02bd902d6346@linaro.org> Date: Tue, 13 Apr 2021 10:50:34 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <58cfb01f-48c9-575e-da53-4a06274c5d69@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 4/13/21 10:36 AM, Simon Marchi wrote: > > > On 2021-04-13 8:22 a.m., Luis Machado via Gdb-patches wrote: >> Replace use of %lx with %s. >> >> gdb/ChangeLog: >> >> YYYY-MM-DD Luis Machado >> >> * rs6000-tdep.c (ppc_displaced_step_fixup): Use %s to print >> hex values. >> --- >> gdb/rs6000-tdep.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c >> index 2415aae342f..347014d6c2f 100644 >> --- a/gdb/rs6000-tdep.c >> +++ b/gdb/rs6000-tdep.c >> @@ -995,8 +995,10 @@ ppc_displaced_step_fixup (struct gdbarch *gdbarch, >> int regnum = (insn & ADDPCIS_TARGET_REGISTER) >> ADDPCIS_INSN_REGSHIFT; >> /* Read and update the target value. */ >> regcache_cooked_read_unsigned (regs, regnum , ¤t_val); >> - displaced_debug_printf ("addpcis target regnum %d was 0x%lx now 0x%lx", >> - regnum, current_val, current_val + displaced_offset ); >> + displaced_debug_printf ("addpcis target regnum %d was %s now %s", >> + regnum, paddress (gdbarch, current_val), >> + paddress (gdbarch, current_val >> + + displaced_offset)); >> regcache_cooked_write_unsigned (regs, regnum, >> current_val + displaced_offset); >> /* point the PC back at the non-displaced instruction. */ >> > > > LGTM, thanks. > > Simon > Thanks, pushed now.