From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jeIiCp+NdWA/MgAAWB0awg (envelope-from ) for ; Tue, 13 Apr 2021 08:25:03 -0400 Received: by simark.ca (Postfix, from userid 112) id 1B0D91F104; Tue, 13 Apr 2021 08:25:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3528A1E783 for ; Tue, 13 Apr 2021 08:25:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D913D394443E; Tue, 13 Apr 2021 12:25:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D913D394443E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1618316701; bh=vPzXMR1+Ums2i2mEbhDk0XR2P1i/5qcfFKV5OFj8ewY=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=EvDUuE5n16r9q7OHGMFK9D+l/ACkW9kAFuH0gt9MyroQLfozekeaKZ8Xf+9PRsg/L Cs2r7llqZsK91PwfCzjanCDrn6Y9X7Dw9IlG54sA8W4rIXD4N8M2f5oiGfhbWmOBym h+AI0ROMbMMw7caVftBeBdaEmLeq+BBqPauGjv+4= Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by sourceware.org (Postfix) with ESMTPS id 973E63854804 for ; Tue, 13 Apr 2021 12:24:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 973E63854804 Received: by mail-qk1-x72e.google.com with SMTP id 18so710283qkl.3 for ; Tue, 13 Apr 2021 05:24:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vPzXMR1+Ums2i2mEbhDk0XR2P1i/5qcfFKV5OFj8ewY=; b=pOyUhpXh1BQ+B8yxqFt1fN9HL2vVBhwi3zXHZeKwojR8RDzlQzpXwYtyd6oK9KIvGC jT4ZL/cBFOjlfhyqP1+p7pYLHlSOK3q6jWiESAywHwjml++N0hgsIFkP7pBFHQc6D8Dt NE5YzP7DOxggVlr0HGV+17/VfDObZptgjWv40H7x2IeOC6xy/xkwP9m/AmcqkhinZaEJ EJwAgUTaCfUy1UsAlz0tQVJra5MnLdWQiS5ALj+6WzDBbtGFkicEeivT0ki+QZyCesoJ SixUAqkciIvmYWd7VdmwQI0NrSZJSTzosGOgY8ujjd8Of4wKTeBVj4JRiG0g+J1vWQfB byEw== X-Gm-Message-State: AOAM530o3NgV7olYA5YLSru24LCbMqLpTuuwm780wWphtGtSijLA3MyI EEY3exUwG4I8QZ9KsXWZ1Mu/7SA6w2npWg== X-Google-Smtp-Source: ABdhPJw2LPvJbtHnf724MBxNX3sIeFidWIfKvltCS9K0a9WgXQrzTboaARLtu2KlBlj5VxGSrGfwNg== X-Received: by 2002:ae9:e403:: with SMTP id q3mr19268214qkc.374.1618316697161; Tue, 13 Apr 2021 05:24:57 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2841:b15b:1248:f1ec:bed5? ([2804:7f0:4841:2841:b15b:1248:f1ec:bed5]) by smtp.gmail.com with ESMTPSA id k21sm106622qkk.13.2021.04.13.05.24.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 05:24:56 -0700 (PDT) Subject: Re: [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all To: gdb-patches@sourceware.org References: <20210413122221.1675458-1-luis.machado@linaro.org> Message-ID: <878016a5-0a0a-86c0-4bfe-f38428aad2e0@linaro.org> Date: Tue, 13 Apr 2021 09:24:54 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210413122221.1675458-1-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Ignore the 6/6. I had a few more cleanups in the queue, but I'm sending those later. On 4/13/21 9:22 AM, Luis Machado wrote: > Replace use of %lx with %s. > > gdb/ChangeLog: > > YYYY-MM-DD Luis Machado > > * rs6000-tdep.c (ppc_displaced_step_fixup): Use %s to print > hex values. > --- > gdb/rs6000-tdep.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c > index 2415aae342f..347014d6c2f 100644 > --- a/gdb/rs6000-tdep.c > +++ b/gdb/rs6000-tdep.c > @@ -995,8 +995,10 @@ ppc_displaced_step_fixup (struct gdbarch *gdbarch, > int regnum = (insn & ADDPCIS_TARGET_REGISTER) >> ADDPCIS_INSN_REGSHIFT; > /* Read and update the target value. */ > regcache_cooked_read_unsigned (regs, regnum , ¤t_val); > - displaced_debug_printf ("addpcis target regnum %d was 0x%lx now 0x%lx", > - regnum, current_val, current_val + displaced_offset ); > + displaced_debug_printf ("addpcis target regnum %d was %s now %s", > + regnum, paddress (gdbarch, current_val), > + paddress (gdbarch, current_val > + + displaced_offset)); > regcache_cooked_write_unsigned (regs, regnum, > current_val + displaced_offset); > /* point the PC back at the non-displaced instruction. */ >