Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all
Date: Tue, 13 Apr 2021 10:50:34 -0300	[thread overview]
Message-ID: <790f6af3-25d9-7d9e-1164-02bd902d6346@linaro.org> (raw)
In-Reply-To: <58cfb01f-48c9-575e-da53-4a06274c5d69@polymtl.ca>

On 4/13/21 10:36 AM, Simon Marchi wrote:
> 
> 
> On 2021-04-13 8:22 a.m., Luis Machado via Gdb-patches wrote:
>> Replace use of %lx with %s.
>>
>> gdb/ChangeLog:
>>
>> YYYY-MM-DD  Luis Machado  <luis.machado@linaro.org>
>>
>> 	* rs6000-tdep.c (ppc_displaced_step_fixup): Use %s to print
>> 	hex values.
>> ---
>>   gdb/rs6000-tdep.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
>> index 2415aae342f..347014d6c2f 100644
>> --- a/gdb/rs6000-tdep.c
>> +++ b/gdb/rs6000-tdep.c
>> @@ -995,8 +995,10 @@ ppc_displaced_step_fixup (struct gdbarch *gdbarch,
>>         int regnum = (insn & ADDPCIS_TARGET_REGISTER) >> ADDPCIS_INSN_REGSHIFT;
>>         /* Read and update the target value.  */
>>         regcache_cooked_read_unsigned (regs, regnum , &current_val);
>> -      displaced_debug_printf ("addpcis target regnum %d was 0x%lx now 0x%lx",
>> -			regnum, current_val, current_val + displaced_offset );
>> +      displaced_debug_printf ("addpcis target regnum %d was %s now %s",
>> +			      regnum, paddress (gdbarch, current_val),
>> +			      paddress (gdbarch, current_val
>> +					+ displaced_offset));
>>         regcache_cooked_write_unsigned (regs, regnum,
>>   					current_val + displaced_offset);
>>         /* point the PC back at the non-displaced instruction.  */
>>
> 
> 
> LGTM, thanks.
> 
> Simon
> 

Thanks, pushed now.

      reply	other threads:[~2021-04-13 13:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 12:22 Luis Machado via Gdb-patches
2021-04-13 12:24 ` Luis Machado via Gdb-patches
2021-04-13 13:36 ` Simon Marchi via Gdb-patches
2021-04-13 13:50   ` Luis Machado via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=790f6af3-25d9-7d9e-1164-02bd902d6346@linaro.org \
    --to=gdb-patches@sourceware.org \
    --cc=luis.machado@linaro.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox