Re: [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-04-13 8:22 a.m., Luis Machado via Gdb-patches wrote:
> Replace use of %lx with %s.
> 
> gdb/ChangeLog:
> 
> YYYY-MM-DD  Luis Machado  <luis.machado@linaro.org>
> 
> 	* rs6000-tdep.c (ppc_displaced_step_fixup): Use %s to print
> 	hex values.
> ---
>  gdb/rs6000-tdep.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
> index 2415aae342f..347014d6c2f 100644
> --- a/gdb/rs6000-tdep.c
> +++ b/gdb/rs6000-tdep.c
> @@ -995,8 +995,10 @@ ppc_displaced_step_fixup (struct gdbarch *gdbarch,
>        int regnum = (insn & ADDPCIS_TARGET_REGISTER) >> ADDPCIS_INSN_REGSHIFT;
>        /* Read and update the target value.  */
>        regcache_cooked_read_unsigned (regs, regnum , &current_val);
> -      displaced_debug_printf ("addpcis target regnum %d was 0x%lx now 0x%lx",
> -			regnum, current_val, current_val + displaced_offset );
> +      displaced_debug_printf ("addpcis target regnum %d was %s now %s",
> +			      regnum, paddress (gdbarch, current_val),
> +			      paddress (gdbarch, current_val
> +					+ displaced_offset));
>        regcache_cooked_write_unsigned (regs, regnum,
>  					current_val + displaced_offset);
>        /* point the PC back at the non-displaced instruction.  */
> 


LGTM, thanks.

Simon