From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /s7iI3iedWD2MwAAWB0awg (envelope-from ) for ; Tue, 13 Apr 2021 09:36:56 -0400 Received: by simark.ca (Postfix, from userid 112) id 84C861F104; Tue, 13 Apr 2021 09:36:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DC8B11E01F for ; Tue, 13 Apr 2021 09:36:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 96AA43943548; Tue, 13 Apr 2021 13:36:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 96AA43943548 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1618321015; bh=24XAEnxDBSAEIAcVMIu0T2CbH0mUVBQwrY+dL4G9Hv4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=LKr7+6jt/bnXCGlMlIVv1rx5ecaRy1LTnoCvBtZPcSzhEOK94Ig/4KPqJrnAtTHBi V0TLASYjY79RCMXFNA+3R9avzsay0bVYYHIew4LHLDyfi3CEXEMWkNdoI84OUawqN9 lYE/NfpTEvtE+Iq3ZCAoFpjQN16ZwmYaEq0g1MC8= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C76A6385702C for ; Tue, 13 Apr 2021 13:36:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C76A6385702C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13DDalwI030093 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Apr 2021 09:36:52 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13DDalwI030093 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C12C01E01F; Tue, 13 Apr 2021 09:36:47 -0400 (EDT) Subject: Re: [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all To: Luis Machado , gdb-patches@sourceware.org References: <20210413122221.1675458-1-luis.machado@linaro.org> Message-ID: <58cfb01f-48c9-575e-da53-4a06274c5d69@polymtl.ca> Date: Tue, 13 Apr 2021 09:36:46 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210413122221.1675458-1-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 13 Apr 2021 13:36:47 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-13 8:22 a.m., Luis Machado via Gdb-patches wrote: > Replace use of %lx with %s. > > gdb/ChangeLog: > > YYYY-MM-DD Luis Machado > > * rs6000-tdep.c (ppc_displaced_step_fixup): Use %s to print > hex values. > --- > gdb/rs6000-tdep.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c > index 2415aae342f..347014d6c2f 100644 > --- a/gdb/rs6000-tdep.c > +++ b/gdb/rs6000-tdep.c > @@ -995,8 +995,10 @@ ppc_displaced_step_fixup (struct gdbarch *gdbarch, > int regnum = (insn & ADDPCIS_TARGET_REGISTER) >> ADDPCIS_INSN_REGSHIFT; > /* Read and update the target value. */ > regcache_cooked_read_unsigned (regs, regnum , ¤t_val); > - displaced_debug_printf ("addpcis target regnum %d was 0x%lx now 0x%lx", > - regnum, current_val, current_val + displaced_offset ); > + displaced_debug_printf ("addpcis target regnum %d was %s now %s", > + regnum, paddress (gdbarch, current_val), > + paddress (gdbarch, current_val > + + displaced_offset)); > regcache_cooked_write_unsigned (regs, regnum, > current_val + displaced_offset); > /* point the PC back at the non-displaced instruction. */ > LGTM, thanks. Simon