From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 6/6] Fix build failure for 32-bit targets with --enable-targets=all
Date: Tue, 13 Apr 2021 09:24:54 -0300 [thread overview]
Message-ID: <878016a5-0a0a-86c0-4bfe-f38428aad2e0@linaro.org> (raw)
In-Reply-To: <20210413122221.1675458-1-luis.machado@linaro.org>
Ignore the 6/6. I had a few more cleanups in the queue, but I'm sending
those later.
On 4/13/21 9:22 AM, Luis Machado wrote:
> Replace use of %lx with %s.
>
> gdb/ChangeLog:
>
> YYYY-MM-DD Luis Machado <luis.machado@linaro.org>
>
> * rs6000-tdep.c (ppc_displaced_step_fixup): Use %s to print
> hex values.
> ---
> gdb/rs6000-tdep.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
> index 2415aae342f..347014d6c2f 100644
> --- a/gdb/rs6000-tdep.c
> +++ b/gdb/rs6000-tdep.c
> @@ -995,8 +995,10 @@ ppc_displaced_step_fixup (struct gdbarch *gdbarch,
> int regnum = (insn & ADDPCIS_TARGET_REGISTER) >> ADDPCIS_INSN_REGSHIFT;
> /* Read and update the target value. */
> regcache_cooked_read_unsigned (regs, regnum , ¤t_val);
> - displaced_debug_printf ("addpcis target regnum %d was 0x%lx now 0x%lx",
> - regnum, current_val, current_val + displaced_offset );
> + displaced_debug_printf ("addpcis target regnum %d was %s now %s",
> + regnum, paddress (gdbarch, current_val),
> + paddress (gdbarch, current_val
> + + displaced_offset));
> regcache_cooked_write_unsigned (regs, regnum,
> current_val + displaced_offset);
> /* point the PC back at the non-displaced instruction. */
>
next prev parent reply other threads:[~2021-04-13 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 12:22 Luis Machado via Gdb-patches
2021-04-13 12:24 ` Luis Machado via Gdb-patches [this message]
2021-04-13 13:36 ` Simon Marchi via Gdb-patches
2021-04-13 13:50 ` Luis Machado via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878016a5-0a0a-86c0-4bfe-f38428aad2e0@linaro.org \
--to=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox