Re: [patch] Speed up find_pc_section

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Wed, 26 Aug 2009 09:20:06 +0200, Paul Pluzhnikov wrote:
> Here is the patch. Tested on Linux/x86_64 and on Fedora11/i686 with
> prelinking. No regressions.
> It also passes Jan's new gdb.base/solib-overlap.exp test case for RH
> Bug 515434, issuing these warnings:

Thanks for the fix.
(No regressions on {x86_64,x86_64-m32,i686}-fedorarawhide-linux-gnu.)


> +  const bfd_vma lma = bfd_section_lma (abfd, section);
> +
> +  if (lma != 0 && lma != bfd_section_vma (abfd, section)
> +      && (bfd_get_file_flags (abfd) & BFD_IN_MEMORY) == 0)
> +    /* This is an overlay section.  IN_MEMORY check is needed to avoid
> +       discarding sections from the "system supplied DSO" (aka vdso)
> +       on Linux.  */

Interesting it exists, do you have a sample + kernel version of such VDSO?


> +  map_size = filter_debuginfo_sections(map, alloc_size);
> +  map_size = filter_overlapping_sections(map, map_size);

GNU spacing.


Thanks,
Jan