From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14433 invoked by alias); 26 Aug 2009 12:04:04 -0000 Received: (qmail 14424 invoked by uid 22791); 26 Aug 2009 12:04:03 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Aug 2009 12:03:57 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7QC3rW3003974; Wed, 26 Aug 2009 08:03:53 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7QC3oLh014633 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 26 Aug 2009 08:03:52 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n7QC3ohW011759; Wed, 26 Aug 2009 14:03:50 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n7QC3nmv011757; Wed, 26 Aug 2009 14:03:49 +0200 Date: Wed, 26 Aug 2009 14:37:00 -0000 From: Jan Kratochvil To: Paul Pluzhnikov Cc: Ulrich Weigand , gdb-patches ml , Tom Tromey Subject: Re: [patch] Speed up find_pc_section Message-ID: <20090826120349.GA10411@host0.dyn.jankratochvil.net> References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> <200908211130.n7LBUCJc011108@d12av02.megacenter.de.ibm.com> <8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> <8ac60eac0908260020l4200cf84v2686a76b5858d13@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ac60eac0908260020l4200cf84v2686a76b5858d13@mail.gmail.com> User-Agent: Mutt/1.5.19 (2009-01-05) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00440.txt.bz2 On Wed, 26 Aug 2009 09:20:06 +0200, Paul Pluzhnikov wrote: > Here is the patch. Tested on Linux/x86_64 and on Fedora11/i686 with > prelinking. No regressions. > It also passes Jan's new gdb.base/solib-overlap.exp test case for RH > Bug 515434, issuing these warnings: Thanks for the fix. (No regressions on {x86_64,x86_64-m32,i686}-fedorarawhide-linux-gnu.) > + const bfd_vma lma = bfd_section_lma (abfd, section); > + > + if (lma != 0 && lma != bfd_section_vma (abfd, section) > + && (bfd_get_file_flags (abfd) & BFD_IN_MEMORY) == 0) > + /* This is an overlay section. IN_MEMORY check is needed to avoid > + discarding sections from the "system supplied DSO" (aka vdso) > + on Linux. */ Interesting it exists, do you have a sample + kernel version of such VDSO? > + map_size = filter_debuginfo_sections(map, alloc_size); > + map_size = filter_overlapping_sections(map, map_size); GNU spacing. Thanks, Jan