From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Bob Rossi <bob@brasko.net>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Hooks still needed for annotations
Date: Fri, 03 Jun 2005 19:09:00 -0000 [thread overview]
Message-ID: <20050603190856.GB32722@nevyn.them.org> (raw)
In-Reply-To: <17054.10607.109160.333076@farnswood.snap.net.nz>
On Thu, Jun 02, 2005 at 09:32:31AM +1200, Nick Roberts wrote:
> I don't currently use breakpoints-invalid but I might wish to at one stage.
> I want to ensure that annotations aren't quietly removed by dismantling them
> bit by bit.
If that's what you want to accomplish, your patch should include test
cases for these annotations. Otherwise they're likely to be "cleaned
up". Also, please do not comment out code; if it's wrong, it should be
deleted.
(I didn't look in to the substance of the patch yet, just this
discussion.)
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-06-03 19:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-01 7:15 Nick Roberts
2005-06-01 11:30 ` Bob Rossi
2005-06-01 21:31 ` Nick Roberts
2005-06-03 19:09 ` Daniel Jacobowitz [this message]
2005-06-03 22:35 ` Nick Roberts
2005-06-03 23:59 ` Daniel Jacobowitz
2005-06-04 3:19 ` Nick Roberts
2005-07-03 17:03 ` Daniel Jacobowitz
2005-07-03 22:13 ` Nick Roberts
2005-07-03 22:44 ` Daniel Jacobowitz
2005-06-04 13:02 ` Bob Rossi
2005-06-13 3:14 ` Daniel Jacobowitz
2005-06-15 15:52 ` Bob Rossi
2005-06-15 16:07 ` Daniel Jacobowitz
2005-06-15 16:31 ` Bob Rossi
2005-07-03 16:45 ` Daniel Jacobowitz
2005-06-15 23:07 ` Nick Roberts
2005-06-15 23:29 ` Bob Rossi
2005-07-01 0:21 ` Bob Rossi
2005-07-01 1:18 ` Nick Roberts
2005-06-06 21:57 ` Nick Roberts
2005-06-10 2:26 ` Bob Rossi
2005-06-10 3:25 ` Nick Roberts
2005-06-15 15:24 ` Bob Rossi
2005-06-15 21:38 ` Nick Roberts
2005-06-15 22:58 ` Bob Rossi
2005-07-03 16:39 ` Daniel Jacobowitz
2005-07-06 15:03 ` Bob Rossi
2005-07-15 0:03 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050603190856.GB32722@nevyn.them.org \
--to=drow@false.org \
--cc=bob@brasko.net \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox