From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30739 invoked by alias); 3 Jun 2005 19:09:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30725 invoked by uid 22791); 3 Jun 2005 19:09:02 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 03 Jun 2005 19:09:02 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DeHXM-000086-2J; Fri, 03 Jun 2005 15:08:56 -0400 Date: Fri, 03 Jun 2005 19:09:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Bob Rossi , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Hooks still needed for annotations Message-ID: <20050603190856.GB32722@nevyn.them.org> Mail-Followup-To: Nick Roberts , Bob Rossi , gdb-patches@sources.redhat.com References: <17053.24737.153388.915345@farnswood.snap.net.nz> <20050601113004.GC15414@white> <17054.10607.109160.333076@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17054.10607.109160.333076@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00027.txt.bz2 On Thu, Jun 02, 2005 at 09:32:31AM +1200, Nick Roberts wrote: > I don't currently use breakpoints-invalid but I might wish to at one stage. > I want to ensure that annotations aren't quietly removed by dismantling them > bit by bit. If that's what you want to accomplish, your patch should include test cases for these annotations. Otherwise they're likely to be "cleaned up". Also, please do not comment out code; if it's wrong, it should be deleted. (I didn't look in to the substance of the patch yet, just this discussion.) -- Daniel Jacobowitz CodeSourcery, LLC