Re: [PATCH] Hooks still needed for annotations

[Daniel Jacobowitz <drow@false.org>]

On Mon, Jul 04, 2005 at 09:52:51AM +1200, Nick Roberts wrote:
>  > Having reread the discussion I would like to ask you what your goal is
>  > with this patch.  You don't use this annotation, and you've said that
>  > it is very awkward to use because of the amount of output it produces.
>  > Why should we fix it (as opposed to garbage collecting it) if no one
>  > has missed it?
> 
> The original authors must have seen a need when they created these
> annotations.  I was just being conservative because there hasn't been a
> release of Emacs to test my code fully.

But the need seems to have gone.  I just don't understand why you're
trying to fix it; you said you didn't use it, so how could your code
rely on it?

>  > The comments in mention() suggest that at one time, GDB was trying to
>  > move away from breakpoints_changed to a more specific set of hooks. 
>  > But now the hooks are more or less dead, and to get full mileage out of
>  > them they're going to need a redesign.  So maybe we should just delete
>  > all three hooks, and replace the two that annotations use with
>  > calls to breakpoints_changed.
> 
> Yes that looks a lot simpler.  If you are agreeable to me fixing it in the
> first place, I will do that.

Might as well, I suppose.

-- 
Daniel Jacobowitz
CodeSourcery, LLC