From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: Bob Rossi <bob@brasko.net>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Hooks still needed for annotations
Date: Sun, 03 Jul 2005 22:13:00 -0000 [thread overview]
Message-ID: <17096.24115.377394.289042@farnswood.snap.net.nz> (raw)
In-Reply-To: <20050703170255.GD13811@nevyn.them.org>
> Having reread the discussion I would like to ask you what your goal is
> with this patch. You don't use this annotation, and you've said that
> it is very awkward to use because of the amount of output it produces.
> Why should we fix it (as opposed to garbage collecting it) if no one
> has missed it?
The original authors must have seen a need when they created these
annotations. I was just being conservative because there hasn't been a
release of Emacs to test my code fully.
> The comments in mention() suggest that at one time, GDB was trying to
> move away from breakpoints_changed to a more specific set of hooks.
> But now the hooks are more or less dead, and to get full mileage out of
> them they're going to need a redesign. So maybe we should just delete
> all three hooks, and replace the two that annotations use with
> calls to breakpoints_changed.
Yes that looks a lot simpler. If you are agreeable to me fixing it in the
first place, I will do that.
Nick
next prev parent reply other threads:[~2005-07-03 22:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-01 7:15 Nick Roberts
2005-06-01 11:30 ` Bob Rossi
2005-06-01 21:31 ` Nick Roberts
2005-06-03 19:09 ` Daniel Jacobowitz
2005-06-03 22:35 ` Nick Roberts
2005-06-03 23:59 ` Daniel Jacobowitz
2005-06-04 3:19 ` Nick Roberts
2005-07-03 17:03 ` Daniel Jacobowitz
2005-07-03 22:13 ` Nick Roberts [this message]
2005-07-03 22:44 ` Daniel Jacobowitz
2005-06-04 13:02 ` Bob Rossi
2005-06-13 3:14 ` Daniel Jacobowitz
2005-06-15 15:52 ` Bob Rossi
2005-06-15 16:07 ` Daniel Jacobowitz
2005-06-15 16:31 ` Bob Rossi
2005-07-03 16:45 ` Daniel Jacobowitz
2005-06-15 23:07 ` Nick Roberts
2005-06-15 23:29 ` Bob Rossi
2005-07-01 0:21 ` Bob Rossi
2005-07-01 1:18 ` Nick Roberts
2005-06-06 21:57 ` Nick Roberts
2005-06-10 2:26 ` Bob Rossi
2005-06-10 3:25 ` Nick Roberts
2005-06-15 15:24 ` Bob Rossi
2005-06-15 21:38 ` Nick Roberts
2005-06-15 22:58 ` Bob Rossi
2005-07-03 16:39 ` Daniel Jacobowitz
2005-07-06 15:03 ` Bob Rossi
2005-07-15 0:03 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17096.24115.377394.289042@farnswood.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=bob@brasko.net \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox