Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: gdb-patches@sources.redhat.com
Subject: [PATCH] Hooks still needed for annotations
Date: Wed, 01 Jun 2005 07:15:00 -0000	[thread overview]
Message-ID: <17053.24737.153388.915345@farnswood.snap.net.nz> (raw)


On 2004-04-21 the lines below were added to clear_interpreter_hooks in
interps.c:

  deprecated_delete_breakpoint_hook = 0;
  deprecated_modify_breakpoint_hook = 0;

Previously they were set to breakpoint_changed (a more natural name would be
annotate_breakpoints_invalid).  This means that sometimes breakpoints-invalid
annotations aren't generated. In particular this is the case when a breakpoint
is toggled between its enabled state and disabled state.

Although the intention is to eventually remove annotations I don't think this
stage has been reached yet and it makes little sense to remove a small
number of calls. The patch below re-instates them.

Nick


2005-06-01  Nick Roberts  <nickrob@snap.net.nz>

	* interps.c (clear_interpreter_hooks):
	Re-instate deprecated_delete_breakpoint_hook and
	deprecated_modify_breakpoint_hook for annotations.


*** /home/nick/src/gdb/interps.c.~1.15.~	2005-04-26 21:44:15.000000000 +1200
--- /home/nick/src/gdb/interps.c	2005-06-01 19:10:35.000000000 +1200
***************
*** 326,333 ****
    deprecated_query_hook = 0;
    deprecated_warning_hook = 0;
    deprecated_create_breakpoint_hook = 0;
!   deprecated_delete_breakpoint_hook = 0;
!   deprecated_modify_breakpoint_hook = 0;
    deprecated_interactive_hook = 0;
    deprecated_registers_changed_hook = 0;
    deprecated_readline_begin_hook = 0;
--- 326,334 ----
    deprecated_query_hook = 0;
    deprecated_warning_hook = 0;
    deprecated_create_breakpoint_hook = 0;
!   /* These hooks are needed for annotations
!      deprecated_delete_breakpoint_hook = 0;
!      deprecated_modify_breakpoint_hook = 0; */
    deprecated_interactive_hook = 0;
    deprecated_registers_changed_hook = 0;
    deprecated_readline_begin_hook = 0;


             reply	other threads:[~2005-06-01  7:15 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-01  7:15 Nick Roberts [this message]
2005-06-01 11:30 ` Bob Rossi
2005-06-01 21:31   ` Nick Roberts
2005-06-03 19:09     ` Daniel Jacobowitz
2005-06-03 22:35       ` Nick Roberts
2005-06-03 23:59         ` Daniel Jacobowitz
2005-06-04  3:19           ` Nick Roberts
2005-07-03 17:03             ` Daniel Jacobowitz
2005-07-03 22:13               ` Nick Roberts
2005-07-03 22:44                 ` Daniel Jacobowitz
2005-06-04 13:02           ` Bob Rossi
2005-06-13  3:14             ` Daniel Jacobowitz
2005-06-15 15:52               ` Bob Rossi
2005-06-15 16:07                 ` Daniel Jacobowitz
2005-06-15 16:31                   ` Bob Rossi
2005-07-03 16:45                     ` Daniel Jacobowitz
2005-06-15 23:07                 ` Nick Roberts
2005-06-15 23:29                   ` Bob Rossi
2005-07-01  0:21               ` Bob Rossi
2005-07-01  1:18                 ` Nick Roberts
2005-06-06 21:57           ` Nick Roberts
2005-06-10  2:26             ` Bob Rossi
2005-06-10  3:25               ` Nick Roberts
2005-06-15 15:24                 ` Bob Rossi
2005-06-15 21:38                   ` Nick Roberts
2005-06-15 22:58                     ` Bob Rossi
2005-07-03 16:39                       ` Daniel Jacobowitz
2005-07-06 15:03                         ` Bob Rossi
2005-07-15  0:03                           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17053.24737.153388.915345@farnswood.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox