From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23125 invoked by alias); 1 Jun 2005 07:15:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23073 invoked by uid 22791); 1 Jun 2005 07:15:20 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 01 Jun 2005 07:15:20 +0000 Received: from farnswood.snap.net.nz (p29-tnt1.snap.net.nz [202.124.110.29]) by viper.snap.net.nz (Postfix) with ESMTP id D6A7E537CC1 for ; Wed, 1 Jun 2005 19:15:16 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id 378D762A99; Wed, 1 Jun 2005 08:15:45 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17053.24737.153388.915345@farnswood.snap.net.nz> Date: Wed, 01 Jun 2005 07:15:00 -0000 To: gdb-patches@sources.redhat.com Subject: [PATCH] Hooks still needed for annotations X-SW-Source: 2005-06/txt/msg00004.txt.bz2 On 2004-04-21 the lines below were added to clear_interpreter_hooks in interps.c: deprecated_delete_breakpoint_hook = 0; deprecated_modify_breakpoint_hook = 0; Previously they were set to breakpoint_changed (a more natural name would be annotate_breakpoints_invalid). This means that sometimes breakpoints-invalid annotations aren't generated. In particular this is the case when a breakpoint is toggled between its enabled state and disabled state. Although the intention is to eventually remove annotations I don't think this stage has been reached yet and it makes little sense to remove a small number of calls. The patch below re-instates them. Nick 2005-06-01 Nick Roberts * interps.c (clear_interpreter_hooks): Re-instate deprecated_delete_breakpoint_hook and deprecated_modify_breakpoint_hook for annotations. *** /home/nick/src/gdb/interps.c.~1.15.~ 2005-04-26 21:44:15.000000000 +1200 --- /home/nick/src/gdb/interps.c 2005-06-01 19:10:35.000000000 +1200 *************** *** 326,333 **** deprecated_query_hook = 0; deprecated_warning_hook = 0; deprecated_create_breakpoint_hook = 0; ! deprecated_delete_breakpoint_hook = 0; ! deprecated_modify_breakpoint_hook = 0; deprecated_interactive_hook = 0; deprecated_registers_changed_hook = 0; deprecated_readline_begin_hook = 0; --- 326,334 ---- deprecated_query_hook = 0; deprecated_warning_hook = 0; deprecated_create_breakpoint_hook = 0; ! /* These hooks are needed for annotations ! deprecated_delete_breakpoint_hook = 0; ! deprecated_modify_breakpoint_hook = 0; */ deprecated_interactive_hook = 0; deprecated_registers_changed_hook = 0; deprecated_readline_begin_hook = 0;