Patch: FYI: use AC_HELP_STRING

Patch: FYI: use AC_HELP_STRING

[Tom Tromey]

This is the patch I promised yesterday.

It fixes the --help output to use upper case where appropriate.
I also took the opportunity to make gdb's configure consistently use
AC_HELP_STRING.

Tom

2009-04-21  Tom Tromey  <tromey@redhat.com>

	* configure: Rebuild.
	* acinclude.m4 (AM_ICONV): Use AC_HELP_STRING.
	* configure.ac: Use AC_HELP_STRING.  Use upper case for variables
	in help.

Index: acinclude.m4
===================================================================
RCS file: /cvs/src/src/gdb/acinclude.m4,v
retrieving revision 1.27
diff -u -r1.27 acinclude.m4
--- acinclude.m4	26 Mar 2009 01:18:35 -0000	1.27
+++ acinclude.m4	21 Apr 2009 16:56:08 -0000
@@ -175,7 +175,7 @@
   dnl those with the standalone portable GNU libiconv installed).
 
   AC_ARG_WITH([libiconv-prefix],
-[  --with-libiconv-prefix=DIR  search for libiconv in DIR/include and DIR/lib], [
+    AC_HELP_STRING([--with-libiconv-prefix=DIR], [search for libiconv in DIR/include and DIR/lib]), [
     for dir in `echo "$withval" | tr : ' '`; do
       if test -d $dir/include; then LIBICONV_INCLUDE="-I$dir/include"; fi
       if test -d $dir/lib; then LIBICONV_LIBDIR="-L$dir/lib"; fi
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.94
diff -u -r1.94 configure.ac
--- configure.ac	21 Apr 2009 10:13:05 -0000	1.94
+++ configure.ac	21 Apr 2009 16:56:10 -0000
@@ -95,7 +95,7 @@
 debugdir=${libdir}/debug
 	 
 AC_ARG_WITH(separate-debug-dir,
-[  --with-separate-debug-dir=path   Look for global separate debug info in this path [LIBDIR/debug]],
+AC_HELP_STRING([--with-separate-debug-dir=PATH], [Look for global separate debug info in this path [LIBDIR/debug]]),
 [debugdir="${withval}"])
 	
 AC_DEFINE_DIR(DEBUGDIR, debugdir,
@@ -129,7 +129,7 @@
 
 # Check whether to support alternative target configurations
 AC_ARG_ENABLE(targets,
-[  --enable-targets        alternative target configurations],
+AC_HELP_STRING([--enable-targets=TARGETS], [alternative target configurations]),
 [case "${enableval}" in
   yes | "") AC_ERROR(enable-targets option must specify target names or 'all')
             ;;
@@ -139,7 +139,7 @@
 
 # Check whether to enable 64-bit support on 32-bit hosts
 AC_ARG_ENABLE(64-bit-bfd,
-[  --enable-64-bit-bfd     64-bit support (on hosts with narrower word sizes)],
+AC_HELP_STRING([--enable-64-bit-bfd], [64-bit support (on hosts with narrower word sizes)]),
 [case "${enableval}" in
   yes)  want64=true  ;;
   no)   want64=false ;;
@@ -247,7 +247,7 @@
 
 # Enable CLI.
 AC_ARG_ENABLE(gdbcli,
-[  --disable-gdbcli        disable command-line interface (CLI)],
+AC_HELP_STRING([--disable-gdbcli], [disable command-line interface (CLI)]),
   [case $enableval in
     yes)
       ;;
@@ -268,7 +268,7 @@
 
 # Enable MI.
 AC_ARG_ENABLE(gdbmi,
-[  --disable-gdbmi         disable machine-interface (MI)],
+AC_HELP_STRING([--disable-gdbmi], [disable machine-interface (MI)]),
   [case $enableval in
     yes | no)
       ;;
@@ -287,7 +287,7 @@
 
 # Enable TUI.
 AC_ARG_ENABLE(tui,
-[  --enable-tui            enable full-screen terminal user interface (TUI)],
+AC_HELP_STRING([--enable-tui], [enable full-screen terminal user interface (TUI)]),
   [case $enableval in
     yes | no | auto)
       ;;
@@ -297,7 +297,7 @@
 
 # Enable gdbtk.
 AC_ARG_ENABLE(gdbtk,
-[  --enable-gdbtk          enable gdbtk graphical user interface (GUI)],
+AC_HELP_STRING([--enable-gdbtk], [enable gdbtk graphical user interface (GUI)]),
   [case $enableval in
     yes | no)
       ;;
@@ -318,7 +318,7 @@
 
 # Libunwind support.
 AC_ARG_WITH(libunwind,
-[  --with-libunwind            Use libunwind frame unwinding support],
+AC_HELP_STRING([--with-libunwind], [Use libunwind frame unwinding support]),
 [case "${withval}" in
   yes)  enable_libunwind=yes ;;
   no)   enable_libunwind=no ;;
@@ -348,7 +348,7 @@
 
 # Profiling support.
 AC_ARG_ENABLE(profiling,
-[  --enable-profiling      enable profiling of GDB],
+AC_HELP_STRING([--enable-profiling], [enable profiling of GDB]),
   [case $enableval in
     yes | no)
       ;;
@@ -927,9 +927,7 @@
 fi
 
 AC_ARG_WITH(included-regex,
-  [  --without-included-regex don't use included regex; this is the default
-                          on systems with version 2 of the GNU C library
-                          (use with caution on other system)],
+  AC_HELP_STRING([--without-included-regex], [don't use included regex; this is the default on systems with version 2 of the GNU C library (use with caution on other system)]),
   gdb_with_regex=$withval,
   gdb_with_regex=$gdb_use_included_regex)
 if test "$gdb_with_regex" = yes; then
@@ -1482,7 +1480,7 @@
 dnl Handle optional features that can be enabled.
 
 AC_ARG_WITH(sysroot,
-[  --with-sysroot[=DIR] Search for usr/lib et al within DIR.],
+AC_HELP_STRING([--with-sysroot[=DIR]], [Search for usr/lib et al within DIR.]),
 [
  case ${with_sysroot} in
  yes) TARGET_SYSTEM_ROOT='${exec_prefix}/${target_alias}/sys-root' ;;
@@ -1519,7 +1517,7 @@
 
 system_gdbinit=
 AC_ARG_WITH(system-gdbinit,
-[  --with-system-gdbinit=file       Automatically load a system-wide gdbinit file],
+AC_HELP_STRING([--with-system-gdbinit=FILE], [Automatically load a system-wide gdbinit file]),
 [system_gdbinit=${withval}])
 
 AC_DEFINE_DIR(SYSTEM_GDBINIT, system_gdbinit,
@@ -1546,7 +1544,7 @@
 esac
 
 AC_ARG_ENABLE(werror,
-  [  --enable-werror    treat compile warnings as errors],
+  AC_HELP_STRING([--enable-werror], [treat compile warnings as errors]),
   [case "${enableval}" in
      yes | y) ERROR_ON_WARNING="yes" ;;
      no | n)  ERROR_ON_WARNING="no" ;;
@@ -1579,7 +1577,7 @@
 esac
 
 AC_ARG_ENABLE(build-warnings,
-[  --enable-build-warnings Enable build-time compiler warnings if gcc is used],
+AC_HELP_STRING([--enable-build-warnings], [Enable build-time compiler warnings if gcc is used]),
 [case "${enableval}" in
   yes)	;;
   no)	build_warnings="-w";;
@@ -1593,7 +1591,7 @@
   echo "Setting compiler warning flags = $build_warnings" 6>&1
 fi])dnl
 AC_ARG_ENABLE(gdb-build-warnings,
-[  --enable-gdb-build-warnings Enable GDB specific build-time compiler warnings if gcc is used],
+AC_HELP_STRING([--enable-gdb-build-warnings], [Enable GDB specific build-time compiler warnings if gcc is used]),
 [case "${enableval}" in
   yes)	;;
   no)	build_warnings="-w";;
@@ -1831,7 +1829,7 @@
 # not part of the source tree.
 #
 AC_ARG_ENABLE(sim,
-[  --enable-sim            Link gdb with simulator],
+AC_HELP_STRING([--enable-sim], [Link gdb with simulator]),
 [echo "enable_sim = $enable_sim";
  echo "enableval = ${enableval}";
  case "${enableval}" in
@@ -1911,7 +1909,7 @@
 
 # Enable multi-ice-gdb-server.
 AC_ARG_ENABLE(multi-ice,
-[  --enable-multi-ice      build the multi-ice-gdb-server],
+AC_HELP_STRING([--enable-multi-ice], [build the multi-ice-gdb-server]),
   [case $enableval in
     yes | no)
       ;;

Re: Patch: FYI: use AC_HELP_STRING

[Andreas Schwab]

Tom Tromey <tromey@redhat.com> writes:

> @@ -95,7 +95,7 @@
>  debugdir=${libdir}/debug
>  	 
>  AC_ARG_WITH(separate-debug-dir,
> -[  --with-separate-debug-dir=path   Look for global separate debug info in this path [LIBDIR/debug]],
> +AC_HELP_STRING([--with-separate-debug-dir=PATH], [Look for global separate debug info in this path [LIBDIR/debug]]),

I think the help text should also start with a lower case.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Patch: FYI: use AC_HELP_STRING

[Tom Tromey]

>>>>> "Andreas" == Andreas Schwab <schwab@linux-m68k.org> writes:

Andreas> I think the help text should also start with a lower case.

Thanks, I didn't notice this.

I'm applying the appended.  It makes this change and also fixes
--with-sysroot so that the help output looks right.

Tom

2009-04-21  Tom Tromey  <tromey@redhat.com>

	* configure: Rebuild.
	* configure.ac: Use lower case for start of help strings.  Clean
	up --with-sysroot help.

Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.95
diff -u -r1.95 configure.ac
--- configure.ac	21 Apr 2009 17:00:17 -0000	1.95
+++ configure.ac	21 Apr 2009 17:53:07 -0000
@@ -95,7 +95,7 @@
 debugdir=${libdir}/debug
 	 
 AC_ARG_WITH(separate-debug-dir,
-AC_HELP_STRING([--with-separate-debug-dir=PATH], [Look for global separate debug info in this path [LIBDIR/debug]]),
+AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]]),
 [debugdir="${withval}"])
 	
 AC_DEFINE_DIR(DEBUGDIR, debugdir,
@@ -119,7 +119,7 @@
 esac
 
 AC_ARG_WITH(relocated-sources,
-AC_HELP_STRING([--with-relocated-sources=PATH], [Automatically relocate this path for source files]),
+AC_HELP_STRING([--with-relocated-sources=PATH], [automatically relocate this path for source files]),
 [reloc_srcdir="${withval}"
  AC_DEFINE_DIR(RELOC_SRCDIR, reloc_srcdir,
               [Relocated directory for source files. ])
@@ -318,7 +318,7 @@
 
 # Libunwind support.
 AC_ARG_WITH(libunwind,
-AC_HELP_STRING([--with-libunwind], [Use libunwind frame unwinding support]),
+AC_HELP_STRING([--with-libunwind], [use libunwind frame unwinding support]),
 [case "${withval}" in
   yes)  enable_libunwind=yes ;;
   no)   enable_libunwind=no ;;
@@ -1480,7 +1480,7 @@
 dnl Handle optional features that can be enabled.
 
 AC_ARG_WITH(sysroot,
-AC_HELP_STRING([--with-sysroot[=DIR]], [Search for usr/lib et al within DIR.]),
+AC_HELP_STRING([--with-sysroot@<:@=DIR@:>@], [search for usr/lib et al within DIR]),
 [
  case ${with_sysroot} in
  yes) TARGET_SYSTEM_ROOT='${exec_prefix}/${target_alias}/sys-root' ;;
@@ -1517,7 +1517,7 @@
 
 system_gdbinit=
 AC_ARG_WITH(system-gdbinit,
-AC_HELP_STRING([--with-system-gdbinit=FILE], [Automatically load a system-wide gdbinit file]),
+AC_HELP_STRING([--with-system-gdbinit=FILE], [automatically load a system-wide gdbinit file]),
 [system_gdbinit=${withval}])
 
 AC_DEFINE_DIR(SYSTEM_GDBINIT, system_gdbinit,
@@ -1577,7 +1577,7 @@
 esac
 
 AC_ARG_ENABLE(build-warnings,
-AC_HELP_STRING([--enable-build-warnings], [Enable build-time compiler warnings if gcc is used]),
+AC_HELP_STRING([--enable-build-warnings], [enable build-time compiler warnings if gcc is used]),
 [case "${enableval}" in
   yes)	;;
   no)	build_warnings="-w";;
@@ -1591,7 +1591,7 @@
   echo "Setting compiler warning flags = $build_warnings" 6>&1
 fi])dnl
 AC_ARG_ENABLE(gdb-build-warnings,
-AC_HELP_STRING([--enable-gdb-build-warnings], [Enable GDB specific build-time compiler warnings if gcc is used]),
+AC_HELP_STRING([--enable-gdb-build-warnings], [enable GDB specific build-time compiler warnings if gcc is used]),
 [case "${enableval}" in
   yes)	;;
   no)	build_warnings="-w";;
@@ -1829,7 +1829,7 @@
 # not part of the source tree.
 #
 AC_ARG_ENABLE(sim,
-AC_HELP_STRING([--enable-sim], [Link gdb with simulator]),
+AC_HELP_STRING([--enable-sim], [link gdb with simulator]),
 [echo "enable_sim = $enable_sim";
  echo "enableval = ${enableval}";
  case "${enableval}" in

Re: Patch: FYI: use AC_HELP_STRING

[Andreas Schwab]

Tom Tromey <tromey@redhat.com> writes:

> diff -u -r1.95 configure.ac
> --- configure.ac	21 Apr 2009 17:00:17 -0000	1.95
> +++ configure.ac	21 Apr 2009 17:53:07 -0000
> @@ -95,7 +95,7 @@
>  debugdir=${libdir}/debug
>  	 
>  AC_ARG_WITH(separate-debug-dir,
> -AC_HELP_STRING([--with-separate-debug-dir=PATH], [Look for global separate debug info in this path [LIBDIR/debug]]),
> +AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]]),
>  [debugdir="${withval}"])

Actually, AC_HELP_STRING is obsoleted by AS_HELP_STRING.  Also, quotes
are missing here that cause the brackets around LIBDIR/debug to be lost.
I've checked this in as obvious to fix the latter.

Andreas.

2009-04-21  Andreas Schwab  <schwab@linux-m68k.org>

	* configure.ac: Add quotes to not lose brackets in help text.
	* configure: Rebuild.

--- configure.ac.~1.98.~	2009-04-21 22:13:57.000000000 +0200
+++ configure.ac	2009-04-21 22:49:16.000000000 +0200
@@ -95,7 +95,7 @@ AM_INIT_AUTOMAKE(gdb, UNUSED-VERSION, [n
 debugdir=${libdir}/debug
 	 
 AC_ARG_WITH(separate-debug-dir,
-AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]]),
+[AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]])],
 [debugdir="${withval}"])
 	
 AC_DEFINE_DIR(DEBUGDIR, debugdir,

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Patch: FYI: use AC_HELP_STRING

[Tom Tromey]

>>>>> "Andreas" == Andreas Schwab <schwab@linux-m68k.org> writes:

Andreas> Actually, AC_HELP_STRING is obsoleted by AS_HELP_STRING.

Thanks, I didn't realize that.  I guess I must be a release behind.

I will fix this up a bit later.

Andreas>  Also, quotes are missing here that cause the brackets around
Andreas> LIBDIR/debug to be lost.  I've checked this in as obvious to
Andreas> fix the latter.

Thanks.

Tom

Re: Patch: FYI: use AC_HELP_STRING

[Tom Tromey]

Andreas> Actually, AC_HELP_STRING is obsoleted by AS_HELP_STRING.

Tom> I will fix this up a bit later.

Here's the patch I'm checking in.

configure doesn't change at all after this patch.

Tom

2009-04-21  Tom Tromey  <tromey@redhat.com>

	* acinclude.m4: Use AS_HELP_STRING, not AC_HELP_STRING.
	* configure.ac: Use AS_HELP_STRING, not AC_HELP_STRING.

Index: acinclude.m4
===================================================================
RCS file: /cvs/src/src/gdb/acinclude.m4,v
retrieving revision 1.28
diff -u -r1.28 acinclude.m4
--- acinclude.m4	21 Apr 2009 17:00:14 -0000	1.28
+++ acinclude.m4	22 Apr 2009 00:10:52 -0000
@@ -175,7 +175,7 @@
   dnl those with the standalone portable GNU libiconv installed).
 
   AC_ARG_WITH([libiconv-prefix],
-    AC_HELP_STRING([--with-libiconv-prefix=DIR], [search for libiconv in DIR/include and DIR/lib]), [
+    AS_HELP_STRING([--with-libiconv-prefix=DIR], [search for libiconv in DIR/include and DIR/lib]), [
     for dir in `echo "$withval" | tr : ' '`; do
       if test -d $dir/include; then LIBICONV_INCLUDE="-I$dir/include"; fi
       if test -d $dir/lib; then LIBICONV_LIBDIR="-L$dir/lib"; fi
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.99
diff -u -r1.99 configure.ac
--- configure.ac	21 Apr 2009 21:01:07 -0000	1.99
+++ configure.ac	22 Apr 2009 00:10:53 -0000
@@ -95,7 +95,7 @@
 debugdir=${libdir}/debug
 	 
 AC_ARG_WITH(separate-debug-dir,
-[AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]])],
+[AS_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]])],
 [debugdir="${withval}"])
 	
 AC_DEFINE_DIR(DEBUGDIR, debugdir,
@@ -119,7 +119,7 @@
 esac
 
 AC_ARG_WITH(relocated-sources,
-AC_HELP_STRING([--with-relocated-sources=PATH], [automatically relocate this path for source files]),
+AS_HELP_STRING([--with-relocated-sources=PATH], [automatically relocate this path for source files]),
 [reloc_srcdir="${withval}"
  AC_DEFINE_DIR(RELOC_SRCDIR, reloc_srcdir,
               [Relocated directory for source files. ])
@@ -129,7 +129,7 @@
 
 # Check whether to support alternative target configurations
 AC_ARG_ENABLE(targets,
-AC_HELP_STRING([--enable-targets=TARGETS], [alternative target configurations]),
+AS_HELP_STRING([--enable-targets=TARGETS], [alternative target configurations]),
 [case "${enableval}" in
   yes | "") AC_ERROR(enable-targets option must specify target names or 'all')
             ;;
@@ -139,7 +139,7 @@
 
 # Check whether to enable 64-bit support on 32-bit hosts
 AC_ARG_ENABLE(64-bit-bfd,
-AC_HELP_STRING([--enable-64-bit-bfd], [64-bit support (on hosts with narrower word sizes)]),
+AS_HELP_STRING([--enable-64-bit-bfd], [64-bit support (on hosts with narrower word sizes)]),
 [case "${enableval}" in
   yes)  want64=true  ;;
   no)   want64=false ;;
@@ -247,7 +247,7 @@
 
 # Enable CLI.
 AC_ARG_ENABLE(gdbcli,
-AC_HELP_STRING([--disable-gdbcli], [disable command-line interface (CLI)]),
+AS_HELP_STRING([--disable-gdbcli], [disable command-line interface (CLI)]),
   [case $enableval in
     yes)
       ;;
@@ -268,7 +268,7 @@
 
 # Enable MI.
 AC_ARG_ENABLE(gdbmi,
-AC_HELP_STRING([--disable-gdbmi], [disable machine-interface (MI)]),
+AS_HELP_STRING([--disable-gdbmi], [disable machine-interface (MI)]),
   [case $enableval in
     yes | no)
       ;;
@@ -287,7 +287,7 @@
 
 # Enable TUI.
 AC_ARG_ENABLE(tui,
-AC_HELP_STRING([--enable-tui], [enable full-screen terminal user interface (TUI)]),
+AS_HELP_STRING([--enable-tui], [enable full-screen terminal user interface (TUI)]),
   [case $enableval in
     yes | no | auto)
       ;;
@@ -297,7 +297,7 @@
 
 # Enable gdbtk.
 AC_ARG_ENABLE(gdbtk,
-AC_HELP_STRING([--enable-gdbtk], [enable gdbtk graphical user interface (GUI)]),
+AS_HELP_STRING([--enable-gdbtk], [enable gdbtk graphical user interface (GUI)]),
   [case $enableval in
     yes | no)
       ;;
@@ -318,7 +318,7 @@
 
 # Libunwind support.
 AC_ARG_WITH(libunwind,
-AC_HELP_STRING([--with-libunwind], [use libunwind frame unwinding support]),
+AS_HELP_STRING([--with-libunwind], [use libunwind frame unwinding support]),
 [case "${withval}" in
   yes)  enable_libunwind=yes ;;
   no)   enable_libunwind=no ;;
@@ -339,7 +339,7 @@
 fi
 
 opt_curses=no
-AC_ARG_WITH(curses, AC_HELP_STRING([--with-curses], [use the curses library instead of the termcap library]), opt_curses=$withval)
+AC_ARG_WITH(curses, AS_HELP_STRING([--with-curses], [use the curses library instead of the termcap library]), opt_curses=$withval)
 
 prefer_curses=no
 if test "$opt_curses" = "yes"; then
@@ -348,7 +348,7 @@
 
 # Profiling support.
 AC_ARG_ENABLE(profiling,
-AC_HELP_STRING([--enable-profiling], [enable profiling of GDB]),
+AS_HELP_STRING([--enable-profiling], [enable profiling of GDB]),
   [case $enableval in
     yes | no)
       ;;
@@ -927,7 +927,7 @@
 fi
 
 AC_ARG_WITH(included-regex,
-  AC_HELP_STRING([--without-included-regex], [don't use included regex; this is the default on systems with version 2 of the GNU C library (use with caution on other system)]),
+  AS_HELP_STRING([--without-included-regex], [don't use included regex; this is the default on systems with version 2 of the GNU C library (use with caution on other system)]),
   gdb_with_regex=$withval,
   gdb_with_regex=$gdb_use_included_regex)
 if test "$gdb_with_regex" = yes; then
@@ -1480,7 +1480,7 @@
 dnl Handle optional features that can be enabled.
 
 AC_ARG_WITH(sysroot,
-AC_HELP_STRING([--with-sysroot@<:@=DIR@:>@], [search for usr/lib et al within DIR]),
+AS_HELP_STRING([--with-sysroot@<:@=DIR@:>@], [search for usr/lib et al within DIR]),
 [
  case ${with_sysroot} in
  yes) TARGET_SYSTEM_ROOT='${exec_prefix}/${target_alias}/sys-root' ;;
@@ -1517,7 +1517,7 @@
 
 system_gdbinit=
 AC_ARG_WITH(system-gdbinit,
-AC_HELP_STRING([--with-system-gdbinit=FILE], [automatically load a system-wide gdbinit file]),
+AS_HELP_STRING([--with-system-gdbinit=FILE], [automatically load a system-wide gdbinit file]),
 [system_gdbinit=${withval}])
 
 AC_DEFINE_DIR(SYSTEM_GDBINIT, system_gdbinit,
@@ -1544,7 +1544,7 @@
 esac
 
 AC_ARG_ENABLE(werror,
-  AC_HELP_STRING([--enable-werror], [treat compile warnings as errors]),
+  AS_HELP_STRING([--enable-werror], [treat compile warnings as errors]),
   [case "${enableval}" in
      yes | y) ERROR_ON_WARNING="yes" ;;
      no | n)  ERROR_ON_WARNING="no" ;;
@@ -1577,7 +1577,7 @@
 esac
 
 AC_ARG_ENABLE(build-warnings,
-AC_HELP_STRING([--enable-build-warnings], [enable build-time compiler warnings if gcc is used]),
+AS_HELP_STRING([--enable-build-warnings], [enable build-time compiler warnings if gcc is used]),
 [case "${enableval}" in
   yes)	;;
   no)	build_warnings="-w";;
@@ -1591,7 +1591,7 @@
   echo "Setting compiler warning flags = $build_warnings" 6>&1
 fi])dnl
 AC_ARG_ENABLE(gdb-build-warnings,
-AC_HELP_STRING([--enable-gdb-build-warnings], [enable GDB specific build-time compiler warnings if gcc is used]),
+AS_HELP_STRING([--enable-gdb-build-warnings], [enable GDB specific build-time compiler warnings if gcc is used]),
 [case "${enableval}" in
   yes)	;;
   no)	build_warnings="-w";;
@@ -1829,7 +1829,7 @@
 # not part of the source tree.
 #
 AC_ARG_ENABLE(sim,
-AC_HELP_STRING([--enable-sim], [link gdb with simulator]),
+AS_HELP_STRING([--enable-sim], [link gdb with simulator]),
 [echo "enable_sim = $enable_sim";
  echo "enableval = ${enableval}";
  case "${enableval}" in
@@ -1909,7 +1909,7 @@
 
 # Enable multi-ice-gdb-server.
 AC_ARG_ENABLE(multi-ice,
-AC_HELP_STRING([--enable-multi-ice], [build the multi-ice-gdb-server]),
+AS_HELP_STRING([--enable-multi-ice], [build the multi-ice-gdb-server]),
   [case $enableval in
     yes | no)
       ;;

Re: Patch: FYI: use AC_HELP_STRING

[Joel Brobecker]

> 2009-04-21  Tom Tromey  <tromey@redhat.com>
> 
> 	* acinclude.m4: Use AS_HELP_STRING, not AC_HELP_STRING.
> 	* configure.ac: Use AS_HELP_STRING, not AC_HELP_STRING.

One thing we might want to do is add AC_HELP_STRING catches
in the gdb ARI. I'm pretty sure I'll have forgotten about this
within the next few days. Thoughts?

-- 
Joel

Re: Patch: FYI: use AC_HELP_STRING

[Tom Tromey]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> * acinclude.m4: Use AS_HELP_STRING, not AC_HELP_STRING.
>> * configure.ac: Use AS_HELP_STRING, not AC_HELP_STRING.

Joel> One thing we might want to do is add AC_HELP_STRING catches
Joel> in the gdb ARI. I'm pretty sure I'll have forgotten about this
Joel> within the next few days. Thoughts?

Yeah, good idea.  I'll do this soon, unless Pierre wants to jump on
it.

I tried autoconf -Wobsolete, but it gave a lot of warnings.
I don't plan to fix this up, but if somebody is really interested in
auto* stuff, I'd support the effort :-)

Tom

RE: Patch: FYI: use AC_HELP_STRING

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé : Wednesday, April 22, 2009 3:45 AM
> À : Joel Brobecker
> Cc : Andreas Schwab; gdb-patches@sourceware.org; muller@ics.u-
> strasbg.fr
> Objet : Re: Patch: FYI: use AC_HELP_STRING
> 
> >>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
> 
> >> * acinclude.m4: Use AS_HELP_STRING, not AC_HELP_STRING.
> >> * configure.ac: Use AS_HELP_STRING, not AC_HELP_STRING.
> 
> Joel> One thing we might want to do is add AC_HELP_STRING catches
> Joel> in the gdb ARI. I'm pretty sure I'll have forgotten about this
> Joel> within the next few days. Thoughts?
> 
> Yeah, good idea.  I'll do this soon, unless Pierre wants to jump on
> it.

  Why not, but currently only files with suffix ".l", ".y", ".h" and ".c"
are listed in gdb_find.sh, and that list 
is currently used by gdb_ari.sh.

  Will AC_HELP_STRING appear in one of these files?
Currently I see AC_HELP_STRING and AS_HELP_STRING
only in gdb/configure.ac file,
which means that gdb_ari.sh will not be useful.

  By the way:

$ grep -R -w AC_HELP_STRING *
ChangeLog:      * acinclude.m4: Use AS_HELP_STRING, not AC_HELP_STRING.
ChangeLog:      * configure.ac: Use AS_HELP_STRING, not AC_HELP_STRING.
ChangeLog:      * acinclude.m4 (AM_ICONV): Use AC_HELP_STRING.
ChangeLog:      * configure.ac: Use AC_HELP_STRING.  Use upper case for
variables
configure.ac:AC_HELP_STRING([--with-datarootdir], [use datarootdir as the
data root directory.]),
configure.ac:AC_HELP_STRING([--with-docdir], [install documentation in this
directory.]),
configure.ac:AC_HELP_STRING([--with-pdfdir], [install pdf in this
directory.]),
configure.ac:AC_HELP_STRING([--with-htmldir], [install html in this
directory.]),
doc/configure.ac:AC_HELP_STRING([--with-datarootdir], [use datarootdir as
the data root directory.]),
doc/configure.ac:AC_HELP_STRING([--with-docdir], [install documentation in
this directory.]),
doc/configure.ac:AC_HELP_STRING([--with-pdfdir], [install pdf in this
directory.]),
doc/configure.ac:AC_HELP_STRING([--with-htmldir], [install html in this
directory.]),

 
Tom, if you want to add this rule, you will need 
to add the list of files that should be parsed,
maybe also add something like
  is_configure_file similar to the is_yacc_or_lex
that I introduced recently, because otherwise
these files will probably give out a lot of 
wrong warnings.

  I tried adding configure.ac to the list and
got a total 182 rules broken by just this one file!

Pierre Muller

Re: Patch: FYI: use AC_HELP_STRING

[Joel Brobecker]

> Why not, but currently only files with suffix ".l", ".y", ".h" and ".c"
> are listed in gdb_find.sh, and that list 
> is currently used by gdb_ari.sh.
> 
> Will AC_HELP_STRING appear in one of these files?
> Currently I see AC_HELP_STRING and AS_HELP_STRING
> only in gdb/configure.ac file,
> which means that gdb_ari.sh will not be useful.

AC_HELP_STRING is an autoconf macro, so it's not just configure.ac.
It could also be any of the .m4 files: aciclude.m4, aclocal.m4, etc.

I didn't realize that these files weren't already ARI'ed. If it's too
much trouble, then we don't have to add a rule for this. It looks like
it would be very easy to fix any regression when the macro disappears,
so reintroducing it wouldn't be really all that harmful.

So I'm fine either way: We can decide to start checking the autoconf
files or not.

-- 
Joel

RE: Patch: FYI: use AC_HELP_STRING

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : Wednesday, April 22, 2009 8:02 PM
> À : Pierre Muller
> Cc : 'Tom Tromey'; 'Andreas Schwab'; gdb-patches@sourceware.org
> Objet : Re: Patch: FYI: use AC_HELP_STRING
> 
> > Why not, but currently only files with suffix ".l", ".y", ".h" and
> ".c"
> > are listed in gdb_find.sh, and that list
> > is currently used by gdb_ari.sh.
> >
> > Will AC_HELP_STRING appear in one of these files?
> > Currently I see AC_HELP_STRING and AS_HELP_STRING
> > only in gdb/configure.ac file,
> > which means that gdb_ari.sh will not be useful.
> 
> AC_HELP_STRING is an autoconf macro, so it's not just configure.ac.
> It could also be any of the .m4 files: aciclude.m4, aclocal.m4, etc.
> 
> I didn't realize that these files weren't already ARI'ed. If it's too
> much trouble, then we don't have to add a rule for this. It looks like
> it would be very easy to fix any regression when the macro disappears,
> so reintroducing it wouldn't be really all that harmful.
> 
> So I'm fine either way: We can decide to start checking the autoconf
> files or not.
> 

  I wouldn't put that on high priority for the moment...

Pierre

Re: Patch: FYI: use AC_HELP_STRING

[Tom Tromey]

>>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:

Joel> So I'm fine either way: We can decide to start checking the autoconf
Joel> files or not.

Pierre>   I wouldn't put that on high priority for the moment...

Let's drop it for now, then.

Tom