From: Tom Tromey <tromey@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Patch: FYI: use AC_HELP_STRING
Date: Tue, 21 Apr 2009 18:08:00 -0000 [thread overview]
Message-ID: <m33ac1282j.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m2ab6avss6.fsf@igel.home> (Andreas Schwab's message of "Tue\, 21 Apr 2009 19\:08\:25 +0200")
>>>>> "Andreas" == Andreas Schwab <schwab@linux-m68k.org> writes:
Andreas> I think the help text should also start with a lower case.
Thanks, I didn't notice this.
I'm applying the appended. It makes this change and also fixes
--with-sysroot so that the help output looks right.
Tom
2009-04-21 Tom Tromey <tromey@redhat.com>
* configure: Rebuild.
* configure.ac: Use lower case for start of help strings. Clean
up --with-sysroot help.
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.95
diff -u -r1.95 configure.ac
--- configure.ac 21 Apr 2009 17:00:17 -0000 1.95
+++ configure.ac 21 Apr 2009 17:53:07 -0000
@@ -95,7 +95,7 @@
debugdir=${libdir}/debug
AC_ARG_WITH(separate-debug-dir,
-AC_HELP_STRING([--with-separate-debug-dir=PATH], [Look for global separate debug info in this path [LIBDIR/debug]]),
+AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]]),
[debugdir="${withval}"])
AC_DEFINE_DIR(DEBUGDIR, debugdir,
@@ -119,7 +119,7 @@
esac
AC_ARG_WITH(relocated-sources,
-AC_HELP_STRING([--with-relocated-sources=PATH], [Automatically relocate this path for source files]),
+AC_HELP_STRING([--with-relocated-sources=PATH], [automatically relocate this path for source files]),
[reloc_srcdir="${withval}"
AC_DEFINE_DIR(RELOC_SRCDIR, reloc_srcdir,
[Relocated directory for source files. ])
@@ -318,7 +318,7 @@
# Libunwind support.
AC_ARG_WITH(libunwind,
-AC_HELP_STRING([--with-libunwind], [Use libunwind frame unwinding support]),
+AC_HELP_STRING([--with-libunwind], [use libunwind frame unwinding support]),
[case "${withval}" in
yes) enable_libunwind=yes ;;
no) enable_libunwind=no ;;
@@ -1480,7 +1480,7 @@
dnl Handle optional features that can be enabled.
AC_ARG_WITH(sysroot,
-AC_HELP_STRING([--with-sysroot[=DIR]], [Search for usr/lib et al within DIR.]),
+AC_HELP_STRING([--with-sysroot@<:@=DIR@:>@], [search for usr/lib et al within DIR]),
[
case ${with_sysroot} in
yes) TARGET_SYSTEM_ROOT='${exec_prefix}/${target_alias}/sys-root' ;;
@@ -1517,7 +1517,7 @@
system_gdbinit=
AC_ARG_WITH(system-gdbinit,
-AC_HELP_STRING([--with-system-gdbinit=FILE], [Automatically load a system-wide gdbinit file]),
+AC_HELP_STRING([--with-system-gdbinit=FILE], [automatically load a system-wide gdbinit file]),
[system_gdbinit=${withval}])
AC_DEFINE_DIR(SYSTEM_GDBINIT, system_gdbinit,
@@ -1577,7 +1577,7 @@
esac
AC_ARG_ENABLE(build-warnings,
-AC_HELP_STRING([--enable-build-warnings], [Enable build-time compiler warnings if gcc is used]),
+AC_HELP_STRING([--enable-build-warnings], [enable build-time compiler warnings if gcc is used]),
[case "${enableval}" in
yes) ;;
no) build_warnings="-w";;
@@ -1591,7 +1591,7 @@
echo "Setting compiler warning flags = $build_warnings" 6>&1
fi])dnl
AC_ARG_ENABLE(gdb-build-warnings,
-AC_HELP_STRING([--enable-gdb-build-warnings], [Enable GDB specific build-time compiler warnings if gcc is used]),
+AC_HELP_STRING([--enable-gdb-build-warnings], [enable GDB specific build-time compiler warnings if gcc is used]),
[case "${enableval}" in
yes) ;;
no) build_warnings="-w";;
@@ -1829,7 +1829,7 @@
# not part of the source tree.
#
AC_ARG_ENABLE(sim,
-AC_HELP_STRING([--enable-sim], [Link gdb with simulator]),
+AC_HELP_STRING([--enable-sim], [link gdb with simulator]),
[echo "enable_sim = $enable_sim";
echo "enableval = ${enableval}";
case "${enableval}" in
next prev parent reply other threads:[~2009-04-21 18:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 16:59 Tom Tromey
2009-04-21 17:08 ` Andreas Schwab
2009-04-21 18:08 ` Tom Tromey [this message]
2009-04-21 21:01 ` Andreas Schwab
2009-04-21 21:07 ` Tom Tromey
2009-04-22 0:18 ` Tom Tromey
2009-04-22 0:59 ` Joel Brobecker
2009-04-22 1:45 ` Tom Tromey
2009-04-22 7:05 ` Pierre Muller
2009-04-22 18:02 ` Joel Brobecker
2009-04-22 21:45 ` Pierre Muller
2009-04-22 22:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33ac1282j.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox