RE: Patch: FYI: use AC_HELP_STRING

["Pierre Muller" <muller@ics.u-strasbg.fr>]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé : Wednesday, April 22, 2009 3:45 AM
> À : Joel Brobecker
> Cc : Andreas Schwab; gdb-patches@sourceware.org; muller@ics.u-
> strasbg.fr
> Objet : Re: Patch: FYI: use AC_HELP_STRING
> 
> >>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
> 
> >> * acinclude.m4: Use AS_HELP_STRING, not AC_HELP_STRING.
> >> * configure.ac: Use AS_HELP_STRING, not AC_HELP_STRING.
> 
> Joel> One thing we might want to do is add AC_HELP_STRING catches
> Joel> in the gdb ARI. I'm pretty sure I'll have forgotten about this
> Joel> within the next few days. Thoughts?
> 
> Yeah, good idea.  I'll do this soon, unless Pierre wants to jump on
> it.

  Why not, but currently only files with suffix ".l", ".y", ".h" and ".c"
are listed in gdb_find.sh, and that list 
is currently used by gdb_ari.sh.

  Will AC_HELP_STRING appear in one of these files?
Currently I see AC_HELP_STRING and AS_HELP_STRING
only in gdb/configure.ac file,
which means that gdb_ari.sh will not be useful.

  By the way:

$ grep -R -w AC_HELP_STRING *
ChangeLog:      * acinclude.m4: Use AS_HELP_STRING, not AC_HELP_STRING.
ChangeLog:      * configure.ac: Use AS_HELP_STRING, not AC_HELP_STRING.
ChangeLog:      * acinclude.m4 (AM_ICONV): Use AC_HELP_STRING.
ChangeLog:      * configure.ac: Use AC_HELP_STRING.  Use upper case for
variables
configure.ac:AC_HELP_STRING([--with-datarootdir], [use datarootdir as the
data root directory.]),
configure.ac:AC_HELP_STRING([--with-docdir], [install documentation in this
directory.]),
configure.ac:AC_HELP_STRING([--with-pdfdir], [install pdf in this
directory.]),
configure.ac:AC_HELP_STRING([--with-htmldir], [install html in this
directory.]),
doc/configure.ac:AC_HELP_STRING([--with-datarootdir], [use datarootdir as
the data root directory.]),
doc/configure.ac:AC_HELP_STRING([--with-docdir], [install documentation in
this directory.]),
doc/configure.ac:AC_HELP_STRING([--with-pdfdir], [install pdf in this
directory.]),
doc/configure.ac:AC_HELP_STRING([--with-htmldir], [install html in this
directory.]),

 
Tom, if you want to add this rule, you will need 
to add the list of files that should be parsed,
maybe also add something like
  is_configure_file similar to the is_yacc_or_lex
that I introduced recently, because otherwise
these files will probably give out a lot of 
wrong warnings.

  I tried adding configure.ac to the list and
got a total 182 rules broken by just this one file!

Pierre Muller