From: Andreas Schwab <schwab@linux-m68k.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Patch: FYI: use AC_HELP_STRING
Date: Tue, 21 Apr 2009 21:01:00 -0000 [thread overview]
Message-ID: <m263gxwwk4.fsf@igel.home> (raw)
In-Reply-To: <m33ac1282j.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue, 21 Apr 2009 12:08:36 -0600")
Tom Tromey <tromey@redhat.com> writes:
> diff -u -r1.95 configure.ac
> --- configure.ac 21 Apr 2009 17:00:17 -0000 1.95
> +++ configure.ac 21 Apr 2009 17:53:07 -0000
> @@ -95,7 +95,7 @@
> debugdir=${libdir}/debug
>
> AC_ARG_WITH(separate-debug-dir,
> -AC_HELP_STRING([--with-separate-debug-dir=PATH], [Look for global separate debug info in this path [LIBDIR/debug]]),
> +AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]]),
> [debugdir="${withval}"])
Actually, AC_HELP_STRING is obsoleted by AS_HELP_STRING. Also, quotes
are missing here that cause the brackets around LIBDIR/debug to be lost.
I've checked this in as obvious to fix the latter.
Andreas.
2009-04-21 Andreas Schwab <schwab@linux-m68k.org>
* configure.ac: Add quotes to not lose brackets in help text.
* configure: Rebuild.
--- configure.ac.~1.98.~ 2009-04-21 22:13:57.000000000 +0200
+++ configure.ac 2009-04-21 22:49:16.000000000 +0200
@@ -95,7 +95,7 @@ AM_INIT_AUTOMAKE(gdb, UNUSED-VERSION, [n
debugdir=${libdir}/debug
AC_ARG_WITH(separate-debug-dir,
-AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]]),
+[AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]])],
[debugdir="${withval}"])
AC_DEFINE_DIR(DEBUGDIR, debugdir,
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2009-04-21 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 16:59 Tom Tromey
2009-04-21 17:08 ` Andreas Schwab
2009-04-21 18:08 ` Tom Tromey
2009-04-21 21:01 ` Andreas Schwab [this message]
2009-04-21 21:07 ` Tom Tromey
2009-04-22 0:18 ` Tom Tromey
2009-04-22 0:59 ` Joel Brobecker
2009-04-22 1:45 ` Tom Tromey
2009-04-22 7:05 ` Pierre Muller
2009-04-22 18:02 ` Joel Brobecker
2009-04-22 21:45 ` Pierre Muller
2009-04-22 22:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m263gxwwk4.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox