From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10693 invoked by alias); 21 Apr 2009 21:01:44 -0000 Received: (qmail 10479 invoked by uid 22791); 21 Apr 2009 21:01:43 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_92 X-Spam-Check-By: sourceware.org Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Apr 2009 21:01:38 +0000 Received: from mail01.m-online.net (mail.m-online.net [192.168.3.149]) by mail-out.m-online.net (Postfix) with ESMTP id 7B5A51C00163; Tue, 21 Apr 2009 23:01:32 +0200 (CEST) Received: from localhost (dynscan2.mnet-online.de [192.168.1.215]) by mail.m-online.net (Postfix) with ESMTP id BCC6890153; Tue, 21 Apr 2009 23:01:34 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.3.149]) by localhost (dynscan2.mnet-online.de [192.168.1.215]) (amavisd-new, port 10024) with ESMTP id y03hOYPX7bS8; Tue, 21 Apr 2009 23:01:33 +0200 (CEST) Received: from igel.home (DSL01.83.171.144.202.ip-pool.NEFkom.net [83.171.144.202]) by mail.mnet-online.de (Postfix) with ESMTP; Tue, 21 Apr 2009 23:01:33 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id 1854610C3FE; Tue, 21 Apr 2009 23:01:31 +0200 (CEST) From: Andreas Schwab To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: Patch: FYI: use AC_HELP_STRING References: X-Yow: An air of FRENCH FRIES permeates my nostrils!! Date: Tue, 21 Apr 2009 21:01:00 -0000 In-Reply-To: (Tom Tromey's message of "Tue, 21 Apr 2009 12:08:36 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00574.txt.bz2 Tom Tromey writes: > diff -u -r1.95 configure.ac > --- configure.ac 21 Apr 2009 17:00:17 -0000 1.95 > +++ configure.ac 21 Apr 2009 17:53:07 -0000 > @@ -95,7 +95,7 @@ > debugdir=${libdir}/debug > > AC_ARG_WITH(separate-debug-dir, > -AC_HELP_STRING([--with-separate-debug-dir=PATH], [Look for global separate debug info in this path [LIBDIR/debug]]), > +AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]]), > [debugdir="${withval}"]) Actually, AC_HELP_STRING is obsoleted by AS_HELP_STRING. Also, quotes are missing here that cause the brackets around LIBDIR/debug to be lost. I've checked this in as obvious to fix the latter. Andreas. 2009-04-21 Andreas Schwab * configure.ac: Add quotes to not lose brackets in help text. * configure: Rebuild. --- configure.ac.~1.98.~ 2009-04-21 22:13:57.000000000 +0200 +++ configure.ac 2009-04-21 22:49:16.000000000 +0200 @@ -95,7 +95,7 @@ AM_INIT_AUTOMAKE(gdb, UNUSED-VERSION, [n debugdir=${libdir}/debug AC_ARG_WITH(separate-debug-dir, -AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]]), +[AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]])], [debugdir="${withval}"]) AC_DEFINE_DIR(DEBUGDIR, debugdir, -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."