From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19996 invoked by alias); 22 Apr 2009 07:05:51 -0000 Received: (qmail 19977 invoked by uid 22791); 22 Apr 2009 07:05:47 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM,J_CHICKENPOX_92 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Apr 2009 07:05:40 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n3M74pvf000610 ; Wed, 22 Apr 2009 09:04:51 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n3M74ot1033077 ; Wed, 22 Apr 2009 09:04:51 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n3M74osH065647 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 22 Apr 2009 09:04:50 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Tom Tromey'" , "'Joel Brobecker'" Cc: "'Andreas Schwab'" , References: <20090422005907.GE5858@adacore.com> In-Reply-To: Subject: RE: Patch: FYI: use AC_HELP_STRING Date: Wed, 22 Apr 2009 07:05:00 -0000 Message-ID: <000901c9c318$a3bf3b60$eb3db220$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00583.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: Wednesday, April 22, 2009 3:45 AM > =C0=A0: Joel Brobecker > Cc=A0: Andreas Schwab; gdb-patches@sourceware.org; muller@ics.u- > strasbg.fr > Objet=A0: Re: Patch: FYI: use AC_HELP_STRING >=20 > >>>>> "Joel" =3D=3D Joel Brobecker writes: >=20 > >> * acinclude.m4: Use AS_HELP_STRING, not AC_HELP_STRING. > >> * configure.ac: Use AS_HELP_STRING, not AC_HELP_STRING. >=20 > Joel> One thing we might want to do is add AC_HELP_STRING catches > Joel> in the gdb ARI. I'm pretty sure I'll have forgotten about this > Joel> within the next few days. Thoughts? >=20 > Yeah, good idea. I'll do this soon, unless Pierre wants to jump on > it. Why not, but currently only files with suffix ".l", ".y", ".h" and ".c" are listed in gdb_find.sh, and that list=20 is currently used by gdb_ari.sh. Will AC_HELP_STRING appear in one of these files? Currently I see AC_HELP_STRING and AS_HELP_STRING only in gdb/configure.ac file, which means that gdb_ari.sh will not be useful. By the way: $ grep -R -w AC_HELP_STRING * ChangeLog: * acinclude.m4: Use AS_HELP_STRING, not AC_HELP_STRING. ChangeLog: * configure.ac: Use AS_HELP_STRING, not AC_HELP_STRING. ChangeLog: * acinclude.m4 (AM_ICONV): Use AC_HELP_STRING. ChangeLog: * configure.ac: Use AC_HELP_STRING. Use upper case for variables configure.ac:AC_HELP_STRING([--with-datarootdir], [use datarootdir as the data root directory.]), configure.ac:AC_HELP_STRING([--with-docdir], [install documentation in this directory.]), configure.ac:AC_HELP_STRING([--with-pdfdir], [install pdf in this directory.]), configure.ac:AC_HELP_STRING([--with-htmldir], [install html in this directory.]), doc/configure.ac:AC_HELP_STRING([--with-datarootdir], [use datarootdir as the data root directory.]), doc/configure.ac:AC_HELP_STRING([--with-docdir], [install documentation in this directory.]), doc/configure.ac:AC_HELP_STRING([--with-pdfdir], [install pdf in this directory.]), doc/configure.ac:AC_HELP_STRING([--with-htmldir], [install html in this directory.]), =20 Tom, if you want to add this rule, you will need=20 to add the list of files that should be parsed, maybe also add something like is_configure_file similar to the is_yacc_or_lex that I introduced recently, because otherwise these files will probably give out a lot of=20 wrong warnings. I tried adding configure.ac to the list and got a total 182 rules broken by just this one file! Pierre Muller