From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24532 invoked by alias); 22 Apr 2009 00:18:00 -0000 Received: (qmail 24515 invoked by uid 22791); 22 Apr 2009 00:17:58 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM,J_CHICKENPOX_92,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Apr 2009 00:17:52 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3M0Hddd017157; Tue, 21 Apr 2009 20:17:39 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3M0HcnC021066; Tue, 21 Apr 2009 20:17:38 -0400 Received: from opsy.redhat.com (vpn-14-116.rdu.redhat.com [10.11.14.116]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n3M0Hb0T004628; Tue, 21 Apr 2009 20:17:38 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id C29D937829A; Tue, 21 Apr 2009 18:17:36 -0600 (MDT) To: Andreas Schwab Cc: gdb-patches@sourceware.org Subject: Re: Patch: FYI: use AC_HELP_STRING References: From: Tom Tromey Reply-To: Tom Tromey Date: Wed, 22 Apr 2009 00:18:00 -0000 In-Reply-To: (Tom Tromey's message of "Tue\, 21 Apr 2009 15\:07\:06 -0600") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00577.txt.bz2 Andreas> Actually, AC_HELP_STRING is obsoleted by AS_HELP_STRING. Tom> I will fix this up a bit later. Here's the patch I'm checking in. configure doesn't change at all after this patch. Tom 2009-04-21 Tom Tromey * acinclude.m4: Use AS_HELP_STRING, not AC_HELP_STRING. * configure.ac: Use AS_HELP_STRING, not AC_HELP_STRING. Index: acinclude.m4 =================================================================== RCS file: /cvs/src/src/gdb/acinclude.m4,v retrieving revision 1.28 diff -u -r1.28 acinclude.m4 --- acinclude.m4 21 Apr 2009 17:00:14 -0000 1.28 +++ acinclude.m4 22 Apr 2009 00:10:52 -0000 @@ -175,7 +175,7 @@ dnl those with the standalone portable GNU libiconv installed). AC_ARG_WITH([libiconv-prefix], - AC_HELP_STRING([--with-libiconv-prefix=DIR], [search for libiconv in DIR/include and DIR/lib]), [ + AS_HELP_STRING([--with-libiconv-prefix=DIR], [search for libiconv in DIR/include and DIR/lib]), [ for dir in `echo "$withval" | tr : ' '`; do if test -d $dir/include; then LIBICONV_INCLUDE="-I$dir/include"; fi if test -d $dir/lib; then LIBICONV_LIBDIR="-L$dir/lib"; fi Index: configure.ac =================================================================== RCS file: /cvs/src/src/gdb/configure.ac,v retrieving revision 1.99 diff -u -r1.99 configure.ac --- configure.ac 21 Apr 2009 21:01:07 -0000 1.99 +++ configure.ac 22 Apr 2009 00:10:53 -0000 @@ -95,7 +95,7 @@ debugdir=${libdir}/debug AC_ARG_WITH(separate-debug-dir, -[AC_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]])], +[AS_HELP_STRING([--with-separate-debug-dir=PATH], [look for global separate debug info in this path [LIBDIR/debug]])], [debugdir="${withval}"]) AC_DEFINE_DIR(DEBUGDIR, debugdir, @@ -119,7 +119,7 @@ esac AC_ARG_WITH(relocated-sources, -AC_HELP_STRING([--with-relocated-sources=PATH], [automatically relocate this path for source files]), +AS_HELP_STRING([--with-relocated-sources=PATH], [automatically relocate this path for source files]), [reloc_srcdir="${withval}" AC_DEFINE_DIR(RELOC_SRCDIR, reloc_srcdir, [Relocated directory for source files. ]) @@ -129,7 +129,7 @@ # Check whether to support alternative target configurations AC_ARG_ENABLE(targets, -AC_HELP_STRING([--enable-targets=TARGETS], [alternative target configurations]), +AS_HELP_STRING([--enable-targets=TARGETS], [alternative target configurations]), [case "${enableval}" in yes | "") AC_ERROR(enable-targets option must specify target names or 'all') ;; @@ -139,7 +139,7 @@ # Check whether to enable 64-bit support on 32-bit hosts AC_ARG_ENABLE(64-bit-bfd, -AC_HELP_STRING([--enable-64-bit-bfd], [64-bit support (on hosts with narrower word sizes)]), +AS_HELP_STRING([--enable-64-bit-bfd], [64-bit support (on hosts with narrower word sizes)]), [case "${enableval}" in yes) want64=true ;; no) want64=false ;; @@ -247,7 +247,7 @@ # Enable CLI. AC_ARG_ENABLE(gdbcli, -AC_HELP_STRING([--disable-gdbcli], [disable command-line interface (CLI)]), +AS_HELP_STRING([--disable-gdbcli], [disable command-line interface (CLI)]), [case $enableval in yes) ;; @@ -268,7 +268,7 @@ # Enable MI. AC_ARG_ENABLE(gdbmi, -AC_HELP_STRING([--disable-gdbmi], [disable machine-interface (MI)]), +AS_HELP_STRING([--disable-gdbmi], [disable machine-interface (MI)]), [case $enableval in yes | no) ;; @@ -287,7 +287,7 @@ # Enable TUI. AC_ARG_ENABLE(tui, -AC_HELP_STRING([--enable-tui], [enable full-screen terminal user interface (TUI)]), +AS_HELP_STRING([--enable-tui], [enable full-screen terminal user interface (TUI)]), [case $enableval in yes | no | auto) ;; @@ -297,7 +297,7 @@ # Enable gdbtk. AC_ARG_ENABLE(gdbtk, -AC_HELP_STRING([--enable-gdbtk], [enable gdbtk graphical user interface (GUI)]), +AS_HELP_STRING([--enable-gdbtk], [enable gdbtk graphical user interface (GUI)]), [case $enableval in yes | no) ;; @@ -318,7 +318,7 @@ # Libunwind support. AC_ARG_WITH(libunwind, -AC_HELP_STRING([--with-libunwind], [use libunwind frame unwinding support]), +AS_HELP_STRING([--with-libunwind], [use libunwind frame unwinding support]), [case "${withval}" in yes) enable_libunwind=yes ;; no) enable_libunwind=no ;; @@ -339,7 +339,7 @@ fi opt_curses=no -AC_ARG_WITH(curses, AC_HELP_STRING([--with-curses], [use the curses library instead of the termcap library]), opt_curses=$withval) +AC_ARG_WITH(curses, AS_HELP_STRING([--with-curses], [use the curses library instead of the termcap library]), opt_curses=$withval) prefer_curses=no if test "$opt_curses" = "yes"; then @@ -348,7 +348,7 @@ # Profiling support. AC_ARG_ENABLE(profiling, -AC_HELP_STRING([--enable-profiling], [enable profiling of GDB]), +AS_HELP_STRING([--enable-profiling], [enable profiling of GDB]), [case $enableval in yes | no) ;; @@ -927,7 +927,7 @@ fi AC_ARG_WITH(included-regex, - AC_HELP_STRING([--without-included-regex], [don't use included regex; this is the default on systems with version 2 of the GNU C library (use with caution on other system)]), + AS_HELP_STRING([--without-included-regex], [don't use included regex; this is the default on systems with version 2 of the GNU C library (use with caution on other system)]), gdb_with_regex=$withval, gdb_with_regex=$gdb_use_included_regex) if test "$gdb_with_regex" = yes; then @@ -1480,7 +1480,7 @@ dnl Handle optional features that can be enabled. AC_ARG_WITH(sysroot, -AC_HELP_STRING([--with-sysroot@<:@=DIR@:>@], [search for usr/lib et al within DIR]), +AS_HELP_STRING([--with-sysroot@<:@=DIR@:>@], [search for usr/lib et al within DIR]), [ case ${with_sysroot} in yes) TARGET_SYSTEM_ROOT='${exec_prefix}/${target_alias}/sys-root' ;; @@ -1517,7 +1517,7 @@ system_gdbinit= AC_ARG_WITH(system-gdbinit, -AC_HELP_STRING([--with-system-gdbinit=FILE], [automatically load a system-wide gdbinit file]), +AS_HELP_STRING([--with-system-gdbinit=FILE], [automatically load a system-wide gdbinit file]), [system_gdbinit=${withval}]) AC_DEFINE_DIR(SYSTEM_GDBINIT, system_gdbinit, @@ -1544,7 +1544,7 @@ esac AC_ARG_ENABLE(werror, - AC_HELP_STRING([--enable-werror], [treat compile warnings as errors]), + AS_HELP_STRING([--enable-werror], [treat compile warnings as errors]), [case "${enableval}" in yes | y) ERROR_ON_WARNING="yes" ;; no | n) ERROR_ON_WARNING="no" ;; @@ -1577,7 +1577,7 @@ esac AC_ARG_ENABLE(build-warnings, -AC_HELP_STRING([--enable-build-warnings], [enable build-time compiler warnings if gcc is used]), +AS_HELP_STRING([--enable-build-warnings], [enable build-time compiler warnings if gcc is used]), [case "${enableval}" in yes) ;; no) build_warnings="-w";; @@ -1591,7 +1591,7 @@ echo "Setting compiler warning flags = $build_warnings" 6>&1 fi])dnl AC_ARG_ENABLE(gdb-build-warnings, -AC_HELP_STRING([--enable-gdb-build-warnings], [enable GDB specific build-time compiler warnings if gcc is used]), +AS_HELP_STRING([--enable-gdb-build-warnings], [enable GDB specific build-time compiler warnings if gcc is used]), [case "${enableval}" in yes) ;; no) build_warnings="-w";; @@ -1829,7 +1829,7 @@ # not part of the source tree. # AC_ARG_ENABLE(sim, -AC_HELP_STRING([--enable-sim], [link gdb with simulator]), +AS_HELP_STRING([--enable-sim], [link gdb with simulator]), [echo "enable_sim = $enable_sim"; echo "enableval = ${enableval}"; case "${enableval}" in @@ -1909,7 +1909,7 @@ # Enable multi-ice-gdb-server. AC_ARG_ENABLE(multi-ice, -AC_HELP_STRING([--enable-multi-ice], [build the multi-ice-gdb-server]), +AS_HELP_STRING([--enable-multi-ice], [build the multi-ice-gdb-server]), [case $enableval in yes | no) ;;