ambiguous linespec decision point

ambiguous linespec decision point

[Tom Tromey]

It is time to decide whether the ambiguous linespec patch should go in
for 7.4 or be delayed until 7.5.  Since I am ready to be done with this
patch, I don't think I can be really objective about it, so I am looking
for input on this topic.

At this point the patch is regression free, according to the test suite,
and Joel has fixed the remaining problems shown by the AdaCore test
suite.

The main risk is just that the patch is quite large and so there may be
regressions lurking that the test suite has not revealed.

I think the absence of any reply, after a day or two, I will check it
all in.

Tom

Re: ambiguous linespec decision point

[Sergio Durigan Junior]

Tom Tromey <tromey@redhat.com> writes:

> It is time to decide whether the ambiguous linespec patch should go in
> for 7.4 or be delayed until 7.5.  Since I am ready to be done with this
> patch, I don't think I can be really objective about it, so I am looking
> for input on this topic.
>
> At this point the patch is regression free, according to the test suite,
> and Joel has fixed the remaining problems shown by the AdaCore test
> suite.
>
> The main risk is just that the patch is quite large and so there may be
> regressions lurking that the test suite has not revealed.

I know my opinion does not count that much, but I think it is OK to
check it in since you both spent quite some time hunting and solving
bugs on this.  Moreover, after the branching we would have two weeks
IIRC to find some regression and fix it.

Re: ambiguous linespec decision point

[Joel Brobecker]

> I know my opinion does not count that much, but I think it is OK to
> check it in since you both spent quite some time hunting and solving
> bugs on this.  Moreover, after the branching we would have two weeks
> IIRC to find some regression and fix it.

I think what I will do if the patch goes in is create the branch
right after, and then wait a week before creating the first pre-
release. And then plan for the official releasee 2 weeks later.
That gives us a week to find potential bugs before we ask for wider
testing...

-- 
Joel

Re: ambiguous linespec decision point

[Gary Benson]

Tom Tromey wrote:
> It is time to decide whether the ambiguous linespec patch should go
> in for 7.4 or be delayed until 7.5.  Since I am ready to be done
> with this patch, I don't think I can be really objective about it,
> so I am looking for input on this topic.
> 
> At this point the patch is regression free, according to the test
> suite, and Joel has fixed the remaining problems shown by the
> AdaCore test suite.
> 
> The main risk is just that the patch is quite large and so there may
> be regressions lurking that the test suite has not revealed.

For what it's worth, I've been using the branch for the past few weeks
while I've been working on the inline function breakpoint stuff, and
I've not noticed anything awful.

Cheers,
Gary

-- 
http://gbenson.net/

Re: ambiguous linespec decision point

[Joel Brobecker]

> For what it's worth, I've been using the branch for the past few weeks
> while I've been working on the inline function breakpoint stuff, and
> I've not noticed anything awful.

I think it's very useful to get feedback from real life use - thank you!

-- 
Joel

Re: ambiguous linespec decision point

[Phil Muldoon]

Sergio Durigan Junior <sergiodj@redhat.com> writes:

> Tom Tromey <tromey@redhat.com> writes:
>
>> It is time to decide whether the ambiguous linespec patch should go in
>> for 7.4 or be delayed until 7.5.  Since I am ready to be done with this
>> patch, I don't think I can be really objective about it, so I am looking
>> for input on this topic.
>>
>> At this point the patch is regression free, according to the test suite,
>> and Joel has fixed the remaining problems shown by the AdaCore test
>> suite.
>>
>> The main risk is just that the patch is quite large and so there may be
>> regressions lurking that the test suite has not revealed.
>
> I know my opinion does not count that much, but I think it is OK to
> check it in since you both spent quite some time hunting and solving
> bugs on this.  Moreover, after the branching we would have two weeks
> IIRC to find some regression and fix it.

I agree with Sergio, and even if the test period goes on a week or two
more, the value this patch would bring is great.

Cheers,

Phil

Re: ambiguous linespec decision point

[Tom Tromey]

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> I think the absence of any reply, after a day or two, I will check it
Tom> all in.

Just FYI, based on current replies, I plan to check this in on Monday.

Tom