From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15758 invoked by alias); 30 Nov 2011 23:15:06 -0000 Received: (qmail 15746 invoked by uid 22791); 30 Nov 2011 23:15:05 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Nov 2011 23:14:32 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAUNEWoY017563 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 30 Nov 2011 18:14:32 -0500 Received: from psique (ovpn-112-33.phx2.redhat.com [10.3.112.33]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pAUNESPX028837; Wed, 30 Nov 2011 18:14:30 -0500 From: Sergio Durigan Junior To: Tom Tromey Cc: GDB Development Subject: Re: ambiguous linespec decision point References: Date: Wed, 30 Nov 2011 23:15:00 -0000 In-Reply-To: (Tom Tromey's message of "Wed, 30 Nov 2011 10:09:52 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00137.txt.bz2 Tom Tromey writes: > It is time to decide whether the ambiguous linespec patch should go in > for 7.4 or be delayed until 7.5. Since I am ready to be done with this > patch, I don't think I can be really objective about it, so I am looking > for input on this topic. > > At this point the patch is regression free, according to the test suite, > and Joel has fixed the remaining problems shown by the AdaCore test > suite. > > The main risk is just that the patch is quite large and so there may be > regressions lurking that the test suite has not revealed. I know my opinion does not count that much, but I think it is OK to check it in since you both spent quite some time hunting and solving bugs on this. Moreover, after the branching we would have two weeks IIRC to find some regression and fix it.