* line_num of gdb_disassembly
@ 2009-03-08 5:48 teawater
2009-03-09 19:51 ` Tom Tromey
0 siblings, 1 reply; 5+ messages in thread
From: teawater @ 2009-03-08 5:48 UTC (permalink / raw)
To: gdb ml
Hi guys,
I found that the argument line_num of gdb_disassembly isn't used in anywhere.
So maybe I can remove it.
And it can be checked in under the obvious rule, right?
Thanks,
Hui
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: line_num of gdb_disassembly
2009-03-08 5:48 line_num of gdb_disassembly teawater
@ 2009-03-09 19:51 ` Tom Tromey
2009-03-09 20:17 ` Pedro Alves
2009-03-10 8:55 ` teawater
0 siblings, 2 replies; 5+ messages in thread
From: Tom Tromey @ 2009-03-09 19:51 UTC (permalink / raw)
To: teawater; +Cc: gdb ml
>>>>> "teawater" == teawater <teawater@gmail.com> writes:
teawater> I found that the argument line_num of gdb_disassembly isn't
teawater> used in anywhere. So maybe I can remove it.
Go for it.
teawater> And it can be checked in under the obvious rule, right?
IMO, yes.
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: line_num of gdb_disassembly
2009-03-09 19:51 ` Tom Tromey
@ 2009-03-09 20:17 ` Pedro Alves
2009-03-10 9:17 ` teawater
2009-03-10 8:55 ` teawater
1 sibling, 1 reply; 5+ messages in thread
From: Pedro Alves @ 2009-03-09 20:17 UTC (permalink / raw)
To: gdb, tromey; +Cc: teawater
Hi guys,
On Monday 09 March 2009 19:50:56, Tom Tromey wrote:
> >>>>> "teawater" == teawater <teawater@gmail.com> writes:
>
> teawater> I found that the argument line_num of gdb_disassembly isn't
> teawater> used in anywhere. So maybe I can remove it.
>
> Go for it.
>
> teawater> And it can be checked in under the obvious rule, right?
>
> IMO, yes.
>
Hui, don't forget that gdb_* functions are part of (now zombie) libgdb's
public interface. There's a chance that insight is using it. You're
not obliged to, but it's always nice to check if insight will need
fixing as well.
--
Pedro Alves
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: line_num of gdb_disassembly
2009-03-09 20:17 ` Pedro Alves
@ 2009-03-10 9:17 ` teawater
0 siblings, 0 replies; 5+ messages in thread
From: teawater @ 2009-03-10 9:17 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb, tromey
Hi Pedro,
Thanks for your remind me about it.
I had checked the insight cvs-head version.
It just use "gdb_print_insn" and "print_asm_fn".
So change gdb_disassembly doesn't affect insight.
Thanks,
Hui
On Tue, Mar 10, 2009 at 04:17, Pedro Alves <pedro@codesourcery.com> wrote:
> Hi guys,
>
> On Monday 09 March 2009 19:50:56, Tom Tromey wrote:
>> >>>>> "teawater" == teawater <teawater@gmail.com> writes:
>>
>> teawater> I found that the argument line_num of gdb_disassembly isn't
>> teawater> used in anywhere. So maybe I can remove it.
>>
>> Go for it.
>>
>> teawater> And it can be checked in under the obvious rule, right?
>>
>> IMO, yes.
>>
>
> Hui, don't forget that gdb_* functions are part of (now zombie) libgdb's
> public interface. There's a chance that insight is using it. You're
> not obliged to, but it's always nice to check if insight will need
> fixing as well.
>
> --
> Pedro Alves
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: line_num of gdb_disassembly
2009-03-09 19:51 ` Tom Tromey
2009-03-09 20:17 ` Pedro Alves
@ 2009-03-10 8:55 ` teawater
1 sibling, 0 replies; 5+ messages in thread
From: teawater @ 2009-03-10 8:55 UTC (permalink / raw)
To: tromey; +Cc: gdb ml
Thanks Tom,
I had checked it in.
Hui
On Tue, Mar 10, 2009 at 03:50, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "teawater" == teawater <teawater@gmail.com> writes:
>
> teawater> I found that the argument line_num of gdb_disassembly isn't
> teawater> used in anywhere. So maybe I can remove it.
>
> Go for it.
>
> teawater> And it can be checked in under the obvious rule, right?
>
> IMO, yes.
>
> Tom
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-03-10 9:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-08 5:48 line_num of gdb_disassembly teawater
2009-03-09 19:51 ` Tom Tromey
2009-03-09 20:17 ` Pedro Alves
2009-03-10 9:17 ` teawater
2009-03-10 8:55 ` teawater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox