From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26781 invoked by alias); 9 Mar 2009 20:17:35 -0000 Received: (qmail 26770 invoked by uid 22791); 9 Mar 2009 20:17:34 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Mar 2009 20:17:27 +0000 Received: (qmail 14682 invoked from network); 9 Mar 2009 20:17:26 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Mar 2009 20:17:26 -0000 From: Pedro Alves To: gdb@sourceware.org, tromey@redhat.com Subject: Re: line_num of gdb_disassembly Date: Mon, 09 Mar 2009 20:17:00 -0000 User-Agent: KMail/1.9.10 Cc: teawater References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903092017.26123.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00068.txt.bz2 Hi guys, On Monday 09 March 2009 19:50:56, Tom Tromey wrote: > >>>>> "teawater" == teawater writes: > > teawater> I found that the argument line_num of gdb_disassembly isn't > teawater> used in anywhere. So maybe I can remove it. > > Go for it. > > teawater> And it can be checked in under the obvious rule, right? > > IMO, yes. > Hui, don't forget that gdb_* functions are part of (now zombie) libgdb's public interface. There's a chance that insight is using it. You're not obliged to, but it's always nice to check if insight will need fixing as well. -- Pedro Alves