From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26647 invoked by alias); 10 Mar 2009 09:17:02 -0000 Received: (qmail 26638 invoked by uid 22791); 10 Mar 2009 09:17:01 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.189) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Mar 2009 09:16:57 +0000 Received: by ti-out-0910.google.com with SMTP id y8so1265029tia.12 for ; Tue, 10 Mar 2009 02:16:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.49.6 with SMTP id w6mr7652278tiw.44.1236676614433; Tue, 10 Mar 2009 02:16:54 -0700 (PDT) In-Reply-To: <200903092017.26123.pedro@codesourcery.com> References: <200903092017.26123.pedro@codesourcery.com> Date: Tue, 10 Mar 2009 09:17:00 -0000 Message-ID: Subject: Re: line_num of gdb_disassembly From: teawater To: Pedro Alves Cc: gdb@sourceware.org, tromey@redhat.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00073.txt.bz2 Hi Pedro, Thanks for your remind me about it. I had checked the insight cvs-head version. It just use "gdb_print_insn" and "print_asm_fn". So change gdb_disassembly doesn't affect insight. Thanks, Hui On Tue, Mar 10, 2009 at 04:17, Pedro Alves wrote: > Hi guys, > > On Monday 09 March 2009 19:50:56, Tom Tromey wrote: >> >>>>> "teawater" =3D=3D teawater =A0 writes: >> >> teawater> I found that the argument line_num of gdb_disassembly isn't >> teawater> used in anywhere. =A0So maybe I can remove it. >> >> Go for it. >> >> teawater> And it can be checked in under the obvious rule, right? >> >> IMO, yes. >> > > Hui, don't forget that gdb_* functions are part of (now zombie) libgdb's > public interface. =A0There's a chance that insight is using it. =A0You're > not obliged to, but it's always nice to check if insight will need > fixing as well. > > -- > Pedro Alves >