From: Pedro Alves <pedro@codesourcery.com>
To: gdb@sourceware.org, tromey@redhat.com
Cc: teawater <teawater@gmail.com>
Subject: Re: line_num of gdb_disassembly
Date: Mon, 09 Mar 2009 20:17:00 -0000 [thread overview]
Message-ID: <200903092017.26123.pedro@codesourcery.com> (raw)
In-Reply-To: <m3mybu4grj.fsf@fleche.redhat.com>
Hi guys,
On Monday 09 March 2009 19:50:56, Tom Tromey wrote:
> >>>>> "teawater" == teawater <teawater@gmail.com> writes:
>
> teawater> I found that the argument line_num of gdb_disassembly isn't
> teawater> used in anywhere. So maybe I can remove it.
>
> Go for it.
>
> teawater> And it can be checked in under the obvious rule, right?
>
> IMO, yes.
>
Hui, don't forget that gdb_* functions are part of (now zombie) libgdb's
public interface. There's a chance that insight is using it. You're
not obliged to, but it's always nice to check if insight will need
fixing as well.
--
Pedro Alves
next prev parent reply other threads:[~2009-03-09 20:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-08 5:48 teawater
2009-03-09 19:51 ` Tom Tromey
2009-03-09 20:17 ` Pedro Alves [this message]
2009-03-10 9:17 ` teawater
2009-03-10 8:55 ` teawater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903092017.26123.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb@sourceware.org \
--cc=teawater@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox