[commit] cli/cli-script.c, script_from_file, add a break stmt for lint

[commit] cli/cli-script.c, script_from_file, add a break stmt for lint

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 13 bytes --]

checked in.


[-- Attachment #2: break8.txt --]
[-- Type: text/plain, Size: 712 bytes --]

2011-03-02  Michael Snyder  <msnyder@vmware.com>

	* cli/cli-script.c (script_from_file): Add break for lint.

Index: cli/cli-script.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-script.c,v
retrieving revision 1.66
diff -u -p -u -p -r1.66 cli-script.c
--- cli/cli-script.c	6 Jan 2011 00:57:02 -0000	1.66
+++ cli/cli-script.c	3 Mar 2011 00:11:55 -0000
@@ -1641,6 +1641,7 @@ script_from_file (FILE *stream, const ch
 	throw_error (e.error,
 		     _("%s:%d: Error in sourced command file:\n%s"),
 		     source_file_name, source_line_number, e.message);
+	break;	/* lint */
       default:
 	internal_error (__FILE__, __LINE__, _("bad reason"));
       }

Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint

[Pedro Alves]

On Thursday 03 March 2011 00:15:55, Michael Snyder wrote:
> checked in.

>   2011-03-02  Michael Snyder  <msnyder@vmware.com>
> 
>         * cli/cli-script.c (script_from_file): Add break for lint.

>         throw_error (e.error,
>                      _("%s:%d: Error in sourced command file:\n%s"),
>                      source_file_name, source_line_number, e.message);
> +       break;  /* lint */

Please don't.  Teach lint about the no-return property of throw_error instead.

>        default:
>         internal_error (__FILE__, __LINE__, _("bad reason"));
>        }

-- 
Pedro Alves

Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint

[Michael Snyder]

Pedro Alves wrote:
> On Thursday 03 March 2011 00:15:55, Michael Snyder wrote:
>> checked in.
> 
>>   2011-03-02  Michael Snyder  <msnyder@vmware.com>
>>
>>         * cli/cli-script.c (script_from_file): Add break for lint.
> 
>>         throw_error (e.error,
>>                      _("%s:%d: Error in sourced command file:\n%s"),
>>                      source_file_name, source_line_number, e.message);
>> +       break;  /* lint */
> 
> Please don't.  Teach lint about the no-return property of throw_error instead.
> 
>>        default:
>>         internal_error (__FILE__, __LINE__, _("bad reason"));
>>        }
> 

I used "lint" loosely, to mean any checker including a human.
It makes things clearer.  There is plenty of precident in gdb:

language.c:  return (struct type *) 0;  /* For lint */
mt-tdep.c:          default:            /* lint */
valarith.c:  return 0;                  /* For lint -- never reached */
valops.c:  return 0;                    /* For lint -- never reached.  */
value.c:  return 0;                     /* Placate lint.  */

Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint

[Tom Tromey]

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> I used "lint" loosely, to mean any checker including a human.

Which one was it in this case?

I think people reading GDB absolutely must know that error,
throw_exception, and some other things cannot return.  Otherwise many
areas of the code will make no sense.

If there is a code checker that doesn't realize this, then it is also
going to spit out a lot of bad reports about GDB.

Michael> It makes things clearer.  There is plenty of precident in gdb:

If we had to choose, I would say these should be removed, rather than
new ones added.

Tom

Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint

[Pedro Alves]

On Thursday 03 March 2011 17:33:05, Michael Snyder wrote:
> > Please don't.  Teach lint about the no-return property of throw_error instead.
> > 
> >>        default:
> >>         internal_error (__FILE__, __LINE__, _("bad reason"));
> >>        }
> > 
> 
> I used "lint" loosely, to mean any checker including a human.

Well, so did I then.  :-)

> It makes things clearer.

I disagree.

-- 
Pedro Alves

Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint

[Michael Snyder]

Pedro Alves wrote:
> On Thursday 03 March 2011 17:33:05, Michael Snyder wrote:
>>> Please don't.  Teach lint about the no-return property of throw_error instead.
>>>
>>>>        default:
>>>>         internal_error (__FILE__, __LINE__, _("bad reason"));
>>>>        }
>> I used "lint" loosely, to mean any checker including a human.
> 
> Well, so did I then.  :-)
> 
>> It makes things clearer.
> 
> I disagree.
> 

OK then.  Reverting this patch.

Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint

[Tom Tromey]

Michael> OK then.  Reverting this patch.

There was another one as well.

Tom