Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: Pedro Alves <pedro@codesourcery.com>,
	       "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint
Date: Thu, 03 Mar 2011 17:48:00 -0000	[thread overview]
Message-ID: <m3hbbkxfgs.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4D6FD0D1.6000506@vmware.com> (Michael Snyder's message of "Thu,	03 Mar 2011 09:33:05 -0800")

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> I used "lint" loosely, to mean any checker including a human.

Which one was it in this case?

I think people reading GDB absolutely must know that error,
throw_exception, and some other things cannot return.  Otherwise many
areas of the code will make no sense.

If there is a code checker that doesn't realize this, then it is also
going to spit out a lot of bad reports about GDB.

Michael> It makes things clearer.  There is plenty of precident in gdb:

If we had to choose, I would say these should be removed, rather than
new ones added.

Tom


  reply	other threads:[~2011-03-03 17:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03  0:16 Michael Snyder
2011-03-03  9:48 ` Pedro Alves
2011-03-03 17:33   ` Michael Snyder
2011-03-03 17:48     ` Tom Tromey [this message]
2011-03-03 17:59     ` Pedro Alves
2011-03-04 18:21       ` Michael Snyder
2011-03-04 18:24         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3hbbkxfgs.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox