From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13510 invoked by alias); 3 Mar 2011 17:48:49 -0000 Received: (qmail 13497 invoked by uid 22791); 3 Mar 2011 17:48:49 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_TM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 17:48:45 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p23HmaG6006350 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 3 Mar 2011 12:48:37 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p23Hmakp013826; Thu, 3 Mar 2011 12:48:36 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p23HmZJ0008436; Thu, 3 Mar 2011 12:48:36 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 63B8A3785EB; Thu, 3 Mar 2011 10:48:35 -0700 (MST) From: Tom Tromey To: Michael Snyder Cc: Pedro Alves , "gdb-patches\@sourceware.org" Subject: Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint References: <4D6EDDBB.9030809@vmware.com> <201103030948.22048.pedro@codesourcery.com> <4D6FD0D1.6000506@vmware.com> Date: Thu, 03 Mar 2011 17:48:00 -0000 In-Reply-To: <4D6FD0D1.6000506@vmware.com> (Michael Snyder's message of "Thu, 03 Mar 2011 09:33:05 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00194.txt.bz2 >>>>> "Michael" == Michael Snyder writes: Michael> I used "lint" loosely, to mean any checker including a human. Which one was it in this case? I think people reading GDB absolutely must know that error, throw_exception, and some other things cannot return. Otherwise many areas of the code will make no sense. If there is a code checker that doesn't realize this, then it is also going to spit out a lot of bad reports about GDB. Michael> It makes things clearer. There is plenty of precident in gdb: If we had to choose, I would say these should be removed, rather than new ones added. Tom