From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21933 invoked by alias); 3 Mar 2011 17:59:18 -0000 Received: (qmail 21924 invoked by uid 22791); 3 Mar 2011 17:59:17 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,TW_TM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 17:59:13 +0000 Received: (qmail 6450 invoked from network); 3 Mar 2011 17:59:11 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 3 Mar 2011 17:59:11 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint Date: Thu, 03 Mar 2011 17:59:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.0; x86_64; ; ) Cc: Michael Snyder References: <4D6EDDBB.9030809@vmware.com> <201103030948.22048.pedro@codesourcery.com> <4D6FD0D1.6000506@vmware.com> In-Reply-To: <4D6FD0D1.6000506@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103031759.21208.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00195.txt.bz2 On Thursday 03 March 2011 17:33:05, Michael Snyder wrote: > > Please don't. Teach lint about the no-return property of throw_error instead. > > > >> default: > >> internal_error (__FILE__, __LINE__, _("bad reason")); > >> } > > > > I used "lint" loosely, to mean any checker including a human. Well, so did I then. :-) > It makes things clearer. I disagree. -- Pedro Alves