From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25935 invoked by alias); 3 Mar 2011 09:48:24 -0000 Received: (qmail 25926 invoked by uid 22791); 3 Mar 2011 09:48:24 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,TW_TM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 09:48:18 +0000 Received: (qmail 24221 invoked from network); 3 Mar 2011 09:48:16 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 3 Mar 2011 09:48:16 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint Date: Thu, 03 Mar 2011 09:48:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.0; x86_64; ; ) Cc: Michael Snyder References: <4D6EDDBB.9030809@vmware.com> In-Reply-To: <4D6EDDBB.9030809@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103030948.22048.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00161.txt.bz2 On Thursday 03 March 2011 00:15:55, Michael Snyder wrote: > checked in. > 2011-03-02 Michael Snyder > > * cli/cli-script.c (script_from_file): Add break for lint. > throw_error (e.error, > _("%s:%d: Error in sourced command file:\n%s"), > source_file_name, source_line_number, e.message); > + break; /* lint */ Please don't. Teach lint about the no-return property of throw_error instead. > default: > internal_error (__FILE__, __LINE__, _("bad reason")); > } -- Pedro Alves